build: Enable some commonly enabled compiler diagnostics

Summary:
> as discussed in [[ bitcoin/bitcoin#17344 | #17344]]
>
> There is a large overlap between this list and Jason Turner's list of recommended compiler diagnostics in the Collaborative Collection of C++ Best Practices (cppbestpractices) project. There is also an overlap with the recommendations given in the C++ Core Guidelines (with editors Bjarne Stroustrup and Herb Sutter).

This is a backport of [[bitcoin/bitcoin#19015 | core#19015]]

Disable `-Wduplicated-branches` for secp256k1, because of some exotic intentional use of ternary operator duplicated branches in test_inverse_scalar.

Test Plan:
```
cmake .. -GNinja -DCMAKE_CXX_FLAGS=-Werror -DCMAKE_C_FLAGS=-Werror
ninja && ninja check && ninja check-secp256k1
rm -Rf *
cmake .. -GNinja  -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_CXX_FLAGS=-Werror  -DCMAKE_C_FLAGS=-Werror
ninja && ninja check && ninja check-secp256k1
```

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10113

src/CMakeLists.txt

@@ -228,10 +228,14 @@ add_compiler_flags(
 	-Wunreachable-code-loop-increment
 	-Wsign-compare
 	-Wconditional-uninitialized
+	-Wduplicated-branches
+	-Wduplicated-cond
+	-Wlogical-op
 )
 add_compiler_flag_group(-Wformat -Wformat-security)
 add_cxx_compiler_flags(
 	-Wredundant-move
+	-Woverloaded-virtual
 )
 
 if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")

src/secp256k1/CMakeLists.txt

@@ -52,6 +52,7 @@ add_c_compiler_flags(
 	-Wnested-externs
 	-Wstrict-prototypes
 	-Wno-long-long
+	-Wno-duplicated-branches
 )
 
 # Default visibility is hidden on all targets.

src/test/rpc_server_tests.cpp

@@ -24,6 +24,9 @@ class ArgsTestRPCCommand : public RPCCommandWithArgsContext {
     explicit ArgsTestRPCCommand(const std::string &nameIn)
         : RPCCommandWithArgsContext(nameIn) {}
 
+    // Suppress a [-Werror=overloaded-virtual] warning
+    using RPCCommandWithArgsContext::Execute;
+
     UniValue Execute(const UniValue &args) const override {
         BOOST_CHECK_EQUAL(args["arg1"].get_str(), "value1");
         return UniValue("testing1");