[p2p] Small follow-ups to 21528

Summary:
Backport of [[bitcoin/bitcoin#22618 | core#22618]].

Depends on D10933.

Ref T1693.

Test Plan:
  ninja all check-all

Reviewers: #bitcoin_abc, tyler-smith, PiRK

Reviewed By: #bitcoin_abc, tyler-smith, PiRK

Subscribers: tyler-smith

Maniphest Tasks: T1693

Differential Revision: https://reviews.bitcoinabc.org/D10934

doc/release-notes.md

@@ -11,3 +11,6 @@ This release includes the following features and fixes:
  - The node will now limit the rate at which the addresses received via p2p messages are processed.
    This can be bypassed if needed by granting the `addr` permission to a peer(see the `-whitelist`
    option for details).
+ - A bitcoind node will no longer gossip addresses to inbound peers by default.
+   They will become eligible for address gossip after sending an ADDR, ADDRV2,
+   or GETADDR message.

src/net_processing.cpp

@@ -5034,7 +5034,9 @@ void PeerManagerImpl::ProcessMessage(
             return;
         }
 
-        SetupAddressRelay(pfrom, *peer);
+        // Since this must be an inbound connection, SetupAddressRelay will
+        // never fail.
+        Assume(SetupAddressRelay(pfrom, *peer));
 
         // Only send one GetAddr response per connection to reduce resource
         // waste and discourage addr stamping of INV announcements.

test/functional/p2p_addr_relay.py

@@ -194,7 +194,7 @@ def relay_tests(self):
         # often sent before the GETADDR response.
         assert_equal(inbound_peer.num_ipv4_received, 0)
 
-        # Send an empty ADDR message to intialize address relay on this
+        # Send an empty ADDR message to initialize address relay on this
         # connection.
         inbound_peer.send_and_ping(msg_addr())