tests: Remove now-unnecessary manual Unload's

Summary: These manual calls to Unload() are no longer necessary because CBlockIndex's no longer live in the heap as of the previous commit. This is a partial backport of [[bitcoin/bitcoin#24050 | core#24050]] bitcoin/bitcoin@531dce0 Depends on D12991 Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D12992
Bitcoin-ABC · Jan 20, 2023 · f225386 · f225386
1 parent f378821
commit f225386
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 5 deletions.
diff --git a/src/test/validation_chainstate_tests.cpp b/src/test/validation_chainstate_tests.cpp
@@ -75,9 +75,6 @@ BOOST_AUTO_TEST_CASE(validation_chainstate_resize_caches) {
         // The view cache should be empty since we had to destruct to downsize.
         BOOST_CHECK(!c1.CoinsTip().HaveCoinInCache(outpoint));
     }
-
-    // Avoid triggering the address sanitizer.
-    WITH_LOCK(::cs_main, manager.Unload());
 }
 
 //! Test UpdateTip behavior for both active and background chainstates.

diff --git a/src/test/validation_chainstatemanager_tests.cpp b/src/test/validation_chainstatemanager_tests.cpp
@@ -105,8 +105,6 @@ BOOST_AUTO_TEST_CASE(chainstatemanager) {
     // Let scheduler events finish running to avoid accessing memory that is
     // going to be unloaded
     SyncWithValidationInterfaceQueue();
-
-    WITH_LOCK(::cs_main, manager.Unload());
 }
 
 //! Test rebalancing the caches associated with each chainstate.