Add dnsseed.electroncash.de #397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We do not use Github for code review. Please submit this patch via https://reviews.bitcoinabc.org |
|
Okay, closing here. |
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Jan 8, 2023
Adds a test suite for the Span class, testing the following features: - Creation - Random access - Popping front and back - Assert failure on attempting to pop an empty span - Equality - Comparison operators - Subspan - Iteration - Corner cases - empty span - very large span Additionally fixes order of files in test CMakeLists. Resolves Bitcoin-ABC#397. Test plan --------- Quick version: - `ninja check-bitcoin-span_tests` Or with detailed output: - `ninja test_bitcoin` - `src/test/test_bitcoin --log_level=all --run_test=span_tests -- DEBUG_LOG_OUT | fgrep -v 'is skipped because disabled'`
ftrader
added a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Jan 8, 2023
Tests for C++20 work-alike Span Closes Bitcoin-ABC#397 See merge request bitcoin-cash-node/bitcoin-cash-node!1661
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bitcoin-seeder is running for a few months (as a systemd service)
It should work 24/7 (I am available via telegram/memo/reddit/e-mail/phone if it doesn't)