Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a page about accounts #867

Closed
Tracked by #1019
Bosch-0 opened this issue Jul 8, 2022 · 7 comments · Fixed by #1040
Closed
Tracked by #1019

Create a page about accounts #867

Bosch-0 opened this issue Jul 8, 2022 · 7 comments · Fixed by #1040
Assignees
Labels
Copy Task is about improving text. Design bitcoin products Referring to the Design BTC product section.

Comments

@Bosch-0
Copy link
Collaborator

Bosch-0 commented Jul 8, 2022

Something we haven't touched on is the guide is the concept of accounts. Its quite an overloaded term and could apply to lots of different things but I think its inevitable bitcoin apps will have accounts in some form in their apps.

I think it would be useful to have some guidance in how you could integrate accounts into a bitcoin application. As accounts are quite general and could apply to any type of bitcoin application I'd suggest creating a page in Designing Bitcoin Products section that goes over things broadly first. We can then use this page to nicely integrate some account based content into our reference designs where relevant.

Things this page could cover:

  • Payments (lightning) vs. savings (on-chain) accounts.
  • Other types of assets accounts (Taro based, liquid, slashtags etc.)
  • Pure application / UI focused accounts (such as having multiple savings (on-chain) or payments (lightning) accounts for different purposes

Accounts can also refer to different user 'profiles' which contain accounts (as detailed above) within them though I'd avoid that terminology and think of a bitcoin wallet as a collection of bitcoin accounts. Similar to how you have a physical wallet that may have bank cards for different accounts you hold at your bank.

Applications that have accounts we can check out:

  • Alby
  • Zeus
  • Bluewallet (they call them wallets but I'd call them accounts)
  • Bitcoin beach (I think Milli is working on something around this)
  • Synonyms wallet once launched
  • Green wallet (have on-chain and liquid accounts)
  • Hexa (lots of different account types)
@Bosch-0 Bosch-0 added Copy Task is about improving text. Design bitcoin products Referring to the Design BTC product section. labels Jul 8, 2022
@Bosch-0
Copy link
Collaborator Author

Bosch-0 commented Jul 8, 2022

Accounts are also a useful companion for unified payment requests if the user is not using a swap address (an on-chain address controlled by a LWS that conducts a swap on any received bitcoin). As the user will need an on-chain account to receive to.

An on-chain account is also needed for lightning-only wallets for channel closures.

@GBKS
Copy link
Contributor

GBKS commented Jul 8, 2022

And not to forget BIP 44 with the derivation path multi-account handling (also see HD wallets), which I think Blockstream Green uses here but most wallets ignore.

image

@rupam870
Copy link

Hey @Bosch-0, is the issue open curently? I was willing to take it up.

@GBKS
Copy link
Contributor

GBKS commented Apr 13, 2023

Here's a nicely executed solution via Family. Don't think it's the best approach though because it creates more onchain overhead. Want to move money from one account to another, you have to make a transaction. The use case of segmenting money into different buckets for different use cases can be just done on a UI level without this overhead. A second criticism would be (and this might just be a thing in the video demo) that wallets for different use cases should function differently. "Lunch money" is probably more in the daily spending category and can be a lightning wallet, while "Rainy day" maybe should be an external-signer setup (higher amounts need better security, convenience is less important).

@GBKS
Copy link
Contributor

GBKS commented Apr 13, 2023

@rupam870 we are discussing this issue in the context of revising the savings wallet reference design. There's a proposal here that you are welcome to chime in on. If you're interested, let's chat in the Slack channel.

@rabbitholiness
Copy link
Collaborator

Trezor also allows for multiple accounts.
Screenshot 2023-06-21 at 12 30 05

@GBKS
Copy link
Contributor

GBKS commented Sep 11, 2023

I'll tackle this one after wrapping up my open PRs. It will be a helpful foundation page for #986 and #777.

GBKS added a commit that referenced this issue Oct 10, 2023
@GBKS GBKS closed this as completed in #1040 Dec 1, 2023
GBKS added a commit that referenced this issue Dec 1, 2023
* New multi-wallet management page

Closes #867 an #986

* Added header image

* Implementing feedback

Pushing updated copy and visuals based on feedback. I am still working through things, but want to make the progress available.

Still a draft. No need to give feedback right now.

* Lots of copy and image iteration

Re-reading the copy, re-writing for clarity, adding image captions, adding more images to flesh out certain flows, etc.

* Adding wallet creation flow example

* Apply suggestions from code review

Co-authored-by: Mogashni  <90313394+mouxdesign@users.noreply.github.com>

* Update _compress_images_cache.yml

* Added new page to the guide intro page

Now it's listed along with the other reference designs.

Also fixed the border radius on one of the images.

* Revision based on feedback

Applying feedback from the two reading sessions.
- Some copy clarifications
- Added unique visuals for wallet types throughout the page for easier recognition
- Few extra links to Stablecoins and Ecash
- New paragraph about application-layer accounts
- Pagination fixes
- Image alt texts

* Moved note sligthtly down and icon update

Based on feedback.

* Image cache file update

Jekyll removed some duplicate entries.

---------

Co-authored-by: Mogashni <90313394+mouxdesign@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Copy Task is about improving text. Design bitcoin products Referring to the Design BTC product section.
Projects
Development

Successfully merging a pull request may close this issue.

4 participants