Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a wallet selector case study #1020

Merged
merged 7 commits into from Jul 6, 2023
Merged

Conversation

GBKS
Copy link
Contributor

@GBKS GBKS commented Jul 3, 2023

This is a new case study page for a UI pattern for choosing an external wallet to use when initiating a transfer in a bitcoin application.

⚒️Check the preview⛏️

Closes #710

This is a new case study page for a UI pattern for choosing an external wallet to use when initiating a transfer in a bitcoin application.

Closes #710
@GBKS GBKS added Copy Task is about improving text. Design Task is about designing something. Case study Issues that is suited as a case study. labels Jul 3, 2023
@GBKS GBKS self-assigned this Jul 3, 2023
@netlify
Copy link

netlify bot commented Jul 3, 2023

Deploy Preview for bitcoin-design-site ready!

Name Link
🔨 Latest commit 3c1ceef
🔍 Latest deploy log https://app.netlify.com/sites/bitcoin-design-site/deploys/64a3ca6dd1f7aa0008f62b8f
😎 Deploy Preview https://deploy-preview-1020--bitcoin-design-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@sbddesign sbddesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great content that is needed! I made several grammar tweaks and fixed an incorrect link.

Nit: I feel like this belongs in the "How It Works" section. I have always thought of the Case Studies section as articles that focus on specific projects and how they solve problems. I guess the PayJoin one is a little different in that regard, but it does go into some detail about how BlueWallet accomplishes it. The conversations I remember when we first started the Case Studies section revolved around letting these be studies on actual projects in the wild. This content reminds me more of the stuff in the How It Works section.

guide/case-studies/wallet-selector.md Outdated Show resolved Hide resolved
guide/case-studies/wallet-selector.md Outdated Show resolved Hide resolved
guide/case-studies/wallet-selector.md Outdated Show resolved Hide resolved
guide/case-studies/wallet-selector.md Outdated Show resolved Hide resolved
guide/case-studies/wallet-selector.md Outdated Show resolved Hide resolved
guide/case-studies/wallet-selector.md Outdated Show resolved Hide resolved
guide/case-studies/wallet-selector.md Outdated Show resolved Hide resolved
guide/case-studies/wallet-selector.md Outdated Show resolved Hide resolved
guide/case-studies/wallet-selector.md Outdated Show resolved Hide resolved
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
@GBKS
Copy link
Contributor Author

GBKS commented Jul 3, 2023

@sbddesign thanks for the feedback, I accepted all your suggestions. Regarding the section, I can go either way. Putting it in the Case studies section makes very slightly more sense to me, but not going to argue if others feel strongly otherwise.

@danielnordh
Copy link
Contributor

Great addition.

Regarding the location of the page.
I also feel that the 'How it works' section could be a good home, but I don't feel strongly enough to say you SHOULD put it there.

Regardless, it seems like this page could use some references to your new page:
https://bitcoin.design/guide/how-it-works/payment-request-formats/

@GBKS
Copy link
Contributor Author

GBKS commented Jul 4, 2023

Thanks for the feedback. I moved the page to "How it works" (getting quite long, that section) and added cross-links to the payment request formats and requesting bitcoin pages.

Copy link
Contributor

@danielnordh danielnordh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sbddesign sbddesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏌️

@sbddesign sbddesign merged commit ec5b46e into master Jul 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Case study Issues that is suited as a case study. Copy Task is about improving text. Design Task is about designing something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linking prefixes for managing inter-app payments
3 participants