New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a wallet selector case study #1020
Conversation
This is a new case study page for a UI pattern for choosing an external wallet to use when initiating a transfer in a bitcoin application. Closes #710
✅ Deploy Preview for bitcoin-design-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great content that is needed! I made several grammar tweaks and fixed an incorrect link.
Nit: I feel like this belongs in the "How It Works" section. I have always thought of the Case Studies section as articles that focus on specific projects and how they solve problems. I guess the PayJoin one is a little different in that regard, but it does go into some detail about how BlueWallet accomplishes it. The conversations I remember when we first started the Case Studies section revolved around letting these be studies on actual projects in the wild. This content reminds me more of the stuff in the How It Works section.
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
@sbddesign thanks for the feedback, I accepted all your suggestions. Regarding the section, I can go either way. Putting it in the |
Great addition. Regarding the location of the page. Regardless, it seems like this page could use some references to your new page: |
Per popular request.
Thanks for the feedback. I moved the page to "How it works" (getting quite long, that section) and added cross-links to the payment request formats and requesting bitcoin pages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏌️
This is a new case study page for a UI pattern for choosing an external wallet to use when initiating a transfer in a bitcoin application.
⚒️Check the preview⛏️
Closes #710