Extract send fees into a page and add scenarios #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Picking up work that Steyn did around various fee scenarios, and tried to marry it with what we have in the guide already. The "Send" page had a lot of fee-related info, but adding more there would have resulted in a very long page. That's why I extracting the fee content into a dedicated page that lives underneath the "Send" page. Closes #997
GBKS
added
Design
✅ Deploy Preview for bitcoin-design-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rabbitholiness
approved these changes
Jul 19, 2023
assets/images/guide/daily-spending-wallet/sending/send-fees/fee-options-custom-options-big.png
Outdated
Show resolved
Hide resolved
mouxdesign
reviewed
Aug 8, 2023
sbddesign
requested changes
Aug 21, 2023
Co-authored-by: Mogashni <90313394+mouxdesign@users.noreply.github.com> Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
|
Thank you for your feedback, dear reviewers. I accepted it all, please take another look and leave your verdict. |
|
Looks good to 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up work that Steyn did around various fee scenarios, and tried to marry it with what we have in the guide already. The "Send" page had a lot of fee-related info, but adding more there would have resulted in a very long page. That's why I extracted the fee content into a dedicated page that lives underneath the "Send" page. The "Send" page now only has a very short paragraph about fees and links out to this new page.
Some content changes:
🧑🏻🏭Check the preview👨🏼🏭
Closes #997