Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting started guide #20

Merged
merged 65 commits into from
Dec 9, 2020

Conversation

GBKS
Copy link
Contributor

@GBKS GBKS commented Sep 1, 2020

Do not merge, this is a work-in-progress branch PR.

@GBKS GBKS self-assigned this Sep 1, 2020
@GBKS GBKS added this to In progress in Content via automation Sep 1, 2020
GBKS and others added 6 commits September 10, 2020 10:21
Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>
Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>
Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>
Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>
Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>
Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>
GBKS and others added 3 commits September 22, 2020 18:31
Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>
Moving all images into folders of the respective page (not just section) they appear in.
Copy added to the common user flows section and minor revisions to other sections.
GBKS and others added 4 commits December 1, 2020 13:14
Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>
Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>
@GBKS
Copy link
Contributor Author

GBKS commented Dec 1, 2020

Yeh I think that could be good, as there is quite a range now

@ConorOkus I created an issue for a page about hardware wallets to address this (at some point in the future).

@GBKS GBKS marked this pull request as ready for review December 1, 2020 12:52
@GBKS GBKS changed the title WIP: Getting started guide Getting started guide Dec 1, 2020
They summarize the goal of each page and some important considerations, to help future contributors more easily understand why things are the way they are.
Copy link

@Rspigler Rspigler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar comments

guide/getting-started/hardware.md Outdated Show resolved Hide resolved
guide/getting-started/software.md Outdated Show resolved Hide resolved
johnsBeharry added a commit to johnsBeharry/bitcoin-design-guide that referenced this pull request Dec 5, 2020
@GBKS getting started pr contains updates to styles that would be used by other writers - while that pr is under review this PR extracts those styles so they can be available to new contributors
@GBKS
Copy link
Contributor Author

GBKS commented Dec 7, 2020

Alright, the section is in good shape, although there's still a lot to refine overall. But I'd still like to merge it into the main branch for now. This will make it easier to tackle individual sections individually, and also allow for easier integration with the other sections that are being worked on (others have said that this would be helpful).

I ticked off the following pre-merge items last week:

  • Checked for dead links
  • Removed unused files
  • Optimized images
  • Added editor’s notes for each page
  • Added image source attribution
  • Added image alt texts

Could you please ACK, NACK, review, discuss, praise, tweak, improve, complain, and anything else you'd like? Bring it all.

@danielnordh
Copy link
Contributor

ACK!
Agree that merging this will make it easier for other chapters, plus it's a great step forward overall.
Good job.

@ConorOkus
Copy link
Collaborator

ACK, good job @GBKS

Copy link
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK (tested locally) with just a few typos I noticed along the way.

This is impressive amount of work Christoph. There are things that can be ironed out at a later point, but I agree with overall feeling that this is needed as a foundation to kick things off.

guide/getting-started/getting-started.md Outdated Show resolved Hide resolved
guide/getting-started/getting-started.md Outdated Show resolved Hide resolved
GBKS and others added 2 commits December 8, 2020 16:23
Co-authored-by: Pavlenex <pavle@pavle.org>
Co-authored-by: Pavlenex <pavle@pavle.org>
Copy link
Contributor

@johnsBeharry johnsBeharry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. I've been using the the tech primer, open source, why bitcoin is unique and why design for bitcoin pages in the mentorship workshops and its already proving really useful so I think getting it released gives us a good foundation to build from. Great work!

@GBKS GBKS merged commit 51eacfc into BitcoinDesign:master Dec 9, 2020
@GBKS GBKS moved this from In progress to Done in Content Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

7 participants