-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting started guide #20
Getting started guide #20
Conversation
Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>
Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>
Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>
Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>
Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>
Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>
Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>
Moving all images into folders of the respective page (not just section) they appear in. Copy added to the common user flows section and minor revisions to other sections.
Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>
Co-authored-by: Conor Okus <conor.okus@hotmail.co.uk>
…/GBKS/Guide into feature/getting-started-guide-v1
@ConorOkus I created an issue for a page about hardware wallets to address this (at some point in the future). |
They summarize the goal of each page and some important considerations, to help future contributors more easily understand why things are the way they are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammar comments
@GBKS getting started pr contains updates to styles that would be used by other writers - while that pr is under review this PR extracts those styles so they can be available to new contributors
Alright, the section is in good shape, although there's still a lot to refine overall. But I'd still like to merge it into the main branch for now. This will make it easier to tackle individual sections individually, and also allow for easier integration with the other sections that are being worked on (others have said that this would be helpful). I ticked off the following pre-merge items last week:
Could you please ACK, NACK, review, discuss, praise, tweak, improve, complain, and anything else you'd like? Bring it all. |
ACK! |
ACK, good job @GBKS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK (tested locally) with just a few typos I noticed along the way.
This is impressive amount of work Christoph. There are things that can be ironed out at a later point, but I agree with overall feeling that this is needed as a foundation to kick things off.
Co-authored-by: Pavlenex <pavle@pavle.org>
Co-authored-by: Pavlenex <pavle@pavle.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK. I've been using the the tech primer, open source, why bitcoin is unique and why design for bitcoin pages in the mentorship workshops and its already proving really useful so I think getting it released gives us a good foundation to build from. Great work!
Do not merge, this is a work-in-progress branch PR.