Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PIN reminders to the daily spending wallet #994

Merged
merged 2 commits into from Mar 23, 2023

Conversation

GBKS
Copy link
Contributor

@GBKS GBKS commented Mar 10, 2023

Adds setting for PIN reminders to the daily spending wallet, and design considerations for these types of security-related reminders. Based on Yashraj's work and the discussion in #599.

PIN reminder setting preview
PIN reminder modal & design consideration copy preview

Closes #599

Adds setting for PIN reminders to the daily spending wallet, and design considerations for these types of security-related reminders.

Closes #599
@GBKS GBKS added the Daily spending wallet Referring to the Daily spending wallet reference design section. label Mar 10, 2023
@GBKS GBKS self-assigned this Mar 10, 2023
@netlify
Copy link

netlify bot commented Mar 10, 2023

Deploy Preview for bitcoin-design-site ready!

Name Link
🔨 Latest commit 0b1b883
🔍 Latest deploy log https://app.netlify.com/sites/bitcoin-design-site/deploys/6412e493e0bcad0008ac9207
😎 Deploy Preview https://deploy-preview-994--bitcoin-design-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@yashrajd yashrajd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Masterfully incorporated my content in a more concise way than I could've managed. Left a few comments. Ack.

guide/daily-spending-wallet/security.md Outdated Show resolved Hide resolved
guide/daily-spending-wallet/security.md Show resolved Hide resolved
@steynviljoen67
Copy link
Contributor

For the reference design for the PIN reminder, have we considered the option to let the user change it on the spot if they can't remember it anymore?

We could have a "Forgot PIN?" button option on the screen. It can either direct them to a section in Settings where they can change it or it can simply let them change it there.

@GBKS
Copy link
Contributor Author

GBKS commented Mar 16, 2023

@yashrajd @steynviljoen67 thanks for the feedback. I made copy and image adjustments accordingly.

Copy link
Contributor

@danielnordh danielnordh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GBKS GBKS merged commit 8551a60 into master Mar 23, 2023
4 checks passed
@GBKS GBKS deleted the feature/daily-spending-additional-reminder-details branch March 23, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily spending wallet Referring to the Daily spending wallet reference design section.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a case study on spaced repetition recovery phrase reminders
4 participants