New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PIN reminders to the daily spending wallet #994
Add PIN reminders to the daily spending wallet #994
Conversation
Adds setting for PIN reminders to the daily spending wallet, and design considerations for these types of security-related reminders. Closes #599
✅ Deploy Preview for bitcoin-design-site ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Masterfully incorporated my content in a more concise way than I could've managed. Left a few comments. Ack.
assets/images/guide/daily-spending-wallet/security/home-pin-reminder.png
Outdated
Show resolved
Hide resolved
For the reference design for the PIN reminder, have we considered the option to let the user change it on the spot if they can't remember it anymore? We could have a "Forgot PIN?" button option on the screen. It can either direct them to a section in Settings where they can change it or it can simply let them change it there. |
Thanks for the input.
@yashrajd @steynviljoen67 thanks for the feedback. I made copy and image adjustments accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds setting for PIN reminders to the daily spending wallet, and design considerations for these types of security-related reminders. Based on Yashraj's work and the discussion in #599.
PIN reminder setting preview
PIN reminder modal & design consideration copy preview
Closes #599