Port Core PR 7907 (Optimize and Cleanup CScript::FindAndDelete) #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function is stl; std::equal just makes more sense.
Thanks to Sergio Lerner for identifying this issue and suggesting this kind of solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port Core PR 7907 bitcoin/bitcoin#7907
ed63062 (Patrick Strateman) Improve worst-case behavior of CScript::FindAndDelete
e777acb (Gavin Andresen) Unit test for CScript::FindAndDelete
23d21c7 (Patrick Strateman) Replace c-style cast with c++ style static_cast.
f026217 (Patrick Strateman) Replace memcmp with std::equal in CScript::FindAndDelete