Improved documentation on how to build a windows binary. #428
Conversation
…with autogen. Added section on how to build on buntu bash on windows. These changes are largly a port of the similar doc in core.
|
Allan, if you are pulling non-trivial changes from the Core project, please "cherry-pick" the changes from their repo so that the original author gets credit for his/her work. When BU hard forks to a larger block size we want these developers to feel welcome contributing to this client. I'm sure that you can google how to do it but basically, "git blame" to find the commit (in this case there are a few dd3457, 7c1716), next add core as a remote to your repository "git remote add core ", then "git fetch core", "git cherry-pick dd3457 7c1716", make any modifications you need to customize to BU (like reverting anything unrelated to what you need), git commit, issue the PR. If its not just one or 2 commits to cherry-pick, you might be able to do it via "git merge", or get most of it and manually copy the rest, etc. |
|
it is also possible to cherry pick a merge commit via: |
|
Ok, will fix in a new pull. |
2cee5fd exhaustive tests: add recovery module (Andrew Poelstra) 678b0e5 exhaustive tests: remove erroneous comment from ecdsa_sig_sign (Andrew Poelstra) 03ff8c2 group_impl.h: remove unused `secp256k1_ge_set_infinity` function (Andrew Poelstra) a724d72 configure: add --enable-coverage to set options for coverage analysis (Andrew Poelstra) b595163 recovery: add tests to cover API misusage (Andrew Poelstra) 6f8ae2f ecdh: test NULL-checking of arguments (Andrew Poelstra) 25e3cfb ecdsa_impl: replace scalar if-checks with VERIFY_CHECKs in ecdsa_sig_sign (Andrew Poelstra)
Summary: The is backport from core. Also amen .arclint so that we don't format 3rd party code. Test Plan: Run the test suite. Reviewers: freetrader, sickpig, MattBitprim Reviewed By: MattBitprim Differential Revision: https://reviews.bitcoinabc.org/D117
I attempted to build a windows binary & I soon realised the current build doc does not work. It was missing a './autogen.sh' command in the middle of the process. I get my code using 'git clone...' but apparently if you get a windows tarball you do not need the 'autogen.sh' rule(?). However this is not apparent to anyone that just does a 'git clone...' of the BU repo. So this issue is fixed in this pull request. (This issue was identified by core some time ago).
I also copied & edited a slab of text from the core repo on how to build using buntu bash on Windows. I tested this works on the BU repo. This is added to the bottom of the document.