Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clang-format.py to include only known-good tested_versions #510

Conversation

ftrader
Copy link
Collaborator

@ftrader ftrader commented May 3, 2017

This PR removes old versions which are not known to produce compatible output with current Travis CI's clang-format 3.8.0.

In particular, 3.6.2, which is included in tested_versions, produced incompatible output on Ubuntu yakkety (on unlimited.cpp).

- 3.6.2 on Yakkety did not produce compatible outputs
- the rest of 3.6.x were not verified, but are not needed since Travis is using 3.8.0
- 3.8.1 was added as it produced compatible results with 3.8.1 (at least the indicated version)
@gandrewstone gandrewstone merged commit fc9b080 into BitcoinUnlimited:dev May 3, 2017
@ftrader ftrader deleted the patch/update_clang_format_tested_versions branch May 3, 2017 22:33
tomasvdw added a commit to tomasvdw/BitcoinUnlimited that referenced this pull request Jun 1, 2018
1e6f1f5ad Merge BitcoinUnlimited#529: fix tests.c in the count == 0 case
95e99f196 fix tests.c in the count == 0 case
452d8e4d2 Merge BitcoinUnlimited#523: scratch: add stack frame support
6fe50439a scratch: add stack frame support
9bc2e2650 Merge BitcoinUnlimited#522: parameterize ecmult_const over input size
7c1b91ba4 parameterize ecmult_const over input size
dbc3ddd5e Merge BitcoinUnlimited#513: Increase sparsity of pippenger fixed window naf representation
fb9271dcf Merge BitcoinUnlimited#510: add a couple missing `const`s to ecmult_pippenger_wnaf
cd5f6028e Merge BitcoinUnlimited#515: Fix typo
09146ae85 Merge BitcoinUnlimited#512: secp256k1_ec_privkey_negate - fix documentation
ec0a7b3ae Don't touch leading zeros in wnaf_fixed.
9e36d1bfe Fix bug in wnaf_fixed where the wnaf array is not completely zeroed when given a 0 scalar.
96f68a0af Don't invert scalar in wnaf_fixed when it is even because a caller might intentionally give a scalar with many leading zeros.
9b7c47a21 Fix typo
6dbb00786 Increase sparsity of pippenger fixed window naf representation
1646ace4d secp256k1_ec_privkey_negate - fix documentation
9b3ff0309 add a couple missing `const`s to ecmult_pippenger_wnaf
cd329dbc3 Merge BitcoinUnlimited#460: [build] Update ax_jni_include_dir.m4 macro
7f9c1a156 Merge BitcoinUnlimited#498: tests: Avoid calling fclose(...) with an invalid argument
f99aa8d4d Merge BitcoinUnlimited#499: tests: Make sure we get the requested number of bytes from /dev/urandom
b549d3d5f Merge BitcoinUnlimited#472: [build] Set --enable-jni to no by default instead of auto.
d33352151 Merge BitcoinUnlimited#494: Support OpenSSL versions >= 1.1 for ENABLE_OPENSSL_TESTS
2ef8ea5d2 Merge BitcoinUnlimited#495: Add bench_ecmult to .gitignore
82a96e458 tests: Make sure we get the requested number of bytes from /dev/urandom
5aae5b5bb Avoid calling fclose(...) with an invalid argument
cb32940df Add bench_ecmult to .gitignore
31abd3ab8 Support OpenSSL versions >= 1.1 for ENABLE_OPENSSL_TESTS
c95f6f136 Merge BitcoinUnlimited#487: fix tests typo, s/changed/unchanged
fb46c8388 Merge BitcoinUnlimited#463: Reduce usage of hardcoded size constants
02f5001df Merge BitcoinUnlimited#490: Disambiguate bench functions and types
1f46d6089 Disambiguate bench functions and types
f54c6c508 Merge BitcoinUnlimited#480: Enable benchmark building by default
c77fc0859 Merge BitcoinUnlimited#486: Add pippenger_wnaf for multi-multiplication
d2f9c6b5d Use more precise pippenger bucket windows
4c950bbea Save some additions per window in _pippenger_wnaf
a58f543f5 Add flags for choosing algorithm in ecmult_multi benchmark
36b22c933 Use scratch space dependent batching in ecmult_multi
355a38f11 Add pippenger_wnaf ecmult_multi
bc65aa794 Add bench_ecmult
dba5471b6 Add ecmult_multi tests
8c1c831bd Generalize Strauss to support multiple points
548de42ec add resizeable scratch space API
0e96cdc6b fix typo, s/changed/unchanged
c7680e570 Reduce usage of hardcoded size constants
6ad5cdb42 Merge BitcoinUnlimited#479: Get rid of reserved _t in type names
7a78f6059 Print whether we're building benchmarks
4afec9f1a Build benchmarks by default
d1dc9dfc0 Get rid of reserved _t in type names
0b7024185 Merge BitcoinUnlimited#474: Fix header guards using reserved identifiers
ab1f89f00 Merge BitcoinUnlimited#478: Fixed multiple typos
8c7ea22d5 Fixed multiple typos
abe2d3e84 Fix header guards using reserved identifiers
57752d28b [build] Set --enable-jni to no by default instead of auto.
f532bdc9f Merge BitcoinUnlimited#459: Add pubkey prefix constants to include/secp256k1.h
cac7c5559 Merge BitcoinUnlimited#470: Fix wnaf_const documentation
768514bac Fix wnaf_const documentation with respect to return value and number of words set
b8c26a399 Merge BitcoinUnlimited#458: Fix typo in API documentation
817fb2013 Merge BitcoinUnlimited#440: Fix typos
12230f90e Merge BitcoinUnlimited#468: Remove redundant conditional expression
2e1ccdca0 Remove redundant conditional expression
e7daa9b3c [build] Tweak JNI macro to warn instead of error for JNI not found.
5b2297792 [build] Update ax_jni_include_dir.m4 macro to deal with recent versions of macOS
bc61b91ac add pubkey prefix constants to include/secp256k1.h
b0452e664 Fix typo in API documentation
84973d393 Merge BitcoinUnlimited#454: Remove residual parts from the schnorr expirement.
5e95bf228 Remove residual parts from the schnorr expirement.
cbc20b8c3 Merge BitcoinUnlimited#452: Minor optimizations to _scalar_inverse to save 4M
4cc8f5250 Merge BitcoinUnlimited#437: Unroll secp256k1_fe_(get|set)_b32 to make them much faster.
465159c27 Further shorten the addition chain for scalar inversion.
a2b6b1914 Fix benchmark print_number infinite loop.
8b7680a82 Unroll secp256k1_fe_(get|set)_b32 for 10x26.
aa8499080 Unroll secp256k1_fe_(get|set)_b32 for 5x52.
cf12fa13c Minor optimizations to _scalar_inverse to save 4M
119949232 Merge BitcoinUnlimited#408: Add `secp256k1_ec_pubkey_negate` and `secp256k1_ec_privkey_negate`
6af087107 Merge BitcoinUnlimited#441: secp256k1_context_randomize: document.
ab31a524b Merge BitcoinUnlimited#444: test: Use checked_alloc
eda5c1a06 Merge BitcoinUnlimited#449: Remove executable bit from secp256k1.c
51b77ae61 Remove executable bit from secp256k1.c
5eb030ca4 test: Use checked_alloc
72d952c9c FIXUP: Missing "is"
70ff29b6a secp256k1_context_randomize: document.
4c0f32ed5 Fix typo: "Agressive" → "Aggressive"
73aca8364 Fix typo: "exectured" → "executed"
8e48aa60d Add `secp256k1_ec_pubkey_negate` and `secp256k1_ec_privkey_negate`

git-subtree-dir: src/secp256k1
git-subtree-split: 1e6f1f5ad5e7f1e3ef79313ec02023902bf8175c
marlengit pushed a commit to marlengit/BitcoinUnlimited that referenced this pull request Sep 25, 2018
1e6f1f5ad Merge BitcoinUnlimited#529: fix tests.c in the count == 0 case
95e99f196 fix tests.c in the count == 0 case
452d8e4d2 Merge BitcoinUnlimited#523: scratch: add stack frame support
6fe50439a scratch: add stack frame support
9bc2e2650 Merge BitcoinUnlimited#522: parameterize ecmult_const over input size
7c1b91ba4 parameterize ecmult_const over input size
dbc3ddd5e Merge BitcoinUnlimited#513: Increase sparsity of pippenger fixed window naf representation
fb9271dcf Merge BitcoinUnlimited#510: add a couple missing `const`s to ecmult_pippenger_wnaf
cd5f6028e Merge BitcoinUnlimited#515: Fix typo
09146ae85 Merge BitcoinUnlimited#512: secp256k1_ec_privkey_negate - fix documentation
ec0a7b3ae Don't touch leading zeros in wnaf_fixed.
9e36d1bfe Fix bug in wnaf_fixed where the wnaf array is not completely zeroed when given a 0 scalar.
96f68a0af Don't invert scalar in wnaf_fixed when it is even because a caller might intentionally give a scalar with many leading zeros.
9b7c47a21 Fix typo
6dbb00786 Increase sparsity of pippenger fixed window naf representation
1646ace4d secp256k1_ec_privkey_negate - fix documentation
9b3ff0309 add a couple missing `const`s to ecmult_pippenger_wnaf
cd329dbc3 Merge BitcoinUnlimited#460: [build] Update ax_jni_include_dir.m4 macro
7f9c1a156 Merge BitcoinUnlimited#498: tests: Avoid calling fclose(...) with an invalid argument
f99aa8d4d Merge BitcoinUnlimited#499: tests: Make sure we get the requested number of bytes from /dev/urandom
b549d3d5f Merge BitcoinUnlimited#472: [build] Set --enable-jni to no by default instead of auto.
d33352151 Merge BitcoinUnlimited#494: Support OpenSSL versions >= 1.1 for ENABLE_OPENSSL_TESTS
2ef8ea5d2 Merge BitcoinUnlimited#495: Add bench_ecmult to .gitignore
82a96e458 tests: Make sure we get the requested number of bytes from /dev/urandom
5aae5b5bb Avoid calling fclose(...) with an invalid argument
cb32940df Add bench_ecmult to .gitignore
31abd3ab8 Support OpenSSL versions >= 1.1 for ENABLE_OPENSSL_TESTS
c95f6f136 Merge BitcoinUnlimited#487: fix tests typo, s/changed/unchanged
fb46c8388 Merge BitcoinUnlimited#463: Reduce usage of hardcoded size constants
02f5001df Merge BitcoinUnlimited#490: Disambiguate bench functions and types
1f46d6089 Disambiguate bench functions and types
f54c6c508 Merge BitcoinUnlimited#480: Enable benchmark building by default
c77fc0859 Merge BitcoinUnlimited#486: Add pippenger_wnaf for multi-multiplication
d2f9c6b5d Use more precise pippenger bucket windows
4c950bbea Save some additions per window in _pippenger_wnaf
a58f543f5 Add flags for choosing algorithm in ecmult_multi benchmark
36b22c933 Use scratch space dependent batching in ecmult_multi
355a38f11 Add pippenger_wnaf ecmult_multi
bc65aa794 Add bench_ecmult
dba5471b6 Add ecmult_multi tests
8c1c831bd Generalize Strauss to support multiple points
548de42ec add resizeable scratch space API
0e96cdc6b fix typo, s/changed/unchanged
c7680e570 Reduce usage of hardcoded size constants
6ad5cdb42 Merge BitcoinUnlimited#479: Get rid of reserved _t in type names
7a78f6059 Print whether we're building benchmarks
4afec9f1a Build benchmarks by default
d1dc9dfc0 Get rid of reserved _t in type names
0b7024185 Merge BitcoinUnlimited#474: Fix header guards using reserved identifiers
ab1f89f00 Merge BitcoinUnlimited#478: Fixed multiple typos
8c7ea22d5 Fixed multiple typos
abe2d3e84 Fix header guards using reserved identifiers
57752d28b [build] Set --enable-jni to no by default instead of auto.
f532bdc9f Merge BitcoinUnlimited#459: Add pubkey prefix constants to include/secp256k1.h
cac7c5559 Merge BitcoinUnlimited#470: Fix wnaf_const documentation
768514bac Fix wnaf_const documentation with respect to return value and number of words set
b8c26a399 Merge BitcoinUnlimited#458: Fix typo in API documentation
817fb2013 Merge BitcoinUnlimited#440: Fix typos
12230f90e Merge BitcoinUnlimited#468: Remove redundant conditional expression
2e1ccdca0 Remove redundant conditional expression
e7daa9b3c [build] Tweak JNI macro to warn instead of error for JNI not found.
5b2297792 [build] Update ax_jni_include_dir.m4 macro to deal with recent versions of macOS
bc61b91ac add pubkey prefix constants to include/secp256k1.h
b0452e664 Fix typo in API documentation
84973d393 Merge BitcoinUnlimited#454: Remove residual parts from the schnorr expirement.
5e95bf228 Remove residual parts from the schnorr expirement.
cbc20b8c3 Merge BitcoinUnlimited#452: Minor optimizations to _scalar_inverse to save 4M
4cc8f5250 Merge BitcoinUnlimited#437: Unroll secp256k1_fe_(get|set)_b32 to make them much faster.
465159c27 Further shorten the addition chain for scalar inversion.
a2b6b1914 Fix benchmark print_number infinite loop.
8b7680a82 Unroll secp256k1_fe_(get|set)_b32 for 10x26.
aa8499080 Unroll secp256k1_fe_(get|set)_b32 for 5x52.
cf12fa13c Minor optimizations to _scalar_inverse to save 4M
119949232 Merge BitcoinUnlimited#408: Add `secp256k1_ec_pubkey_negate` and `secp256k1_ec_privkey_negate`
6af087107 Merge BitcoinUnlimited#441: secp256k1_context_randomize: document.
ab31a524b Merge BitcoinUnlimited#444: test: Use checked_alloc
eda5c1a06 Merge BitcoinUnlimited#449: Remove executable bit from secp256k1.c
51b77ae61 Remove executable bit from secp256k1.c
5eb030ca4 test: Use checked_alloc
72d952c9c FIXUP: Missing "is"
70ff29b6a secp256k1_context_randomize: document.
4c0f32ed5 Fix typo: "Agressive" → "Aggressive"
73aca8364 Fix typo: "exectured" → "executed"
8e48aa60d Add `secp256k1_ec_pubkey_negate` and `secp256k1_ec_privkey_negate`

git-subtree-dir: src/secp256k1
git-subtree-split: 1e6f1f5ad5e7f1e3ef79313ec02023902bf8175c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants