Fix unwanted AttributeError in messagetypes

Bitmessage · Jul 5, 2019 · 8b065d2 · 8b065d2
1 parent c9bc97f
commit 8b065d2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/messagetypes/message.py b/src/messagetypes/message.py
@@ -23,7 +23,7 @@ def encode(self, data):
             self.data["subject"] = data["subject"]
             self.data["body"] = data["body"]
         except KeyError as e:
-            logger.error("Missing key %s", e.name)
+            logger.error("Missing key %s", e)
         return self.data
 
     def process(self):

diff --git a/src/tests/core.py b/src/tests/core.py
@@ -70,6 +70,14 @@ def test_msgcoding(self):
         self.assertEqual(msg_data['subject'], obj3e.subject)
         self.assertEqual(msg_data['body'], obj3e.body)
 
+        try:
+            MsgEncode({'body': 'A msg with no subject'}, 3)
+        except Exception as e:
+            self.fail(
+                'Exception %s whyle trying to encode message'
+                ' with no subject!' % e
+            )
+
     def _wipe_knownnodes(self):
         with knownnodes.knownNodesLock:
             knownnodes.knownNodes = {stream: {} for stream in range(1, 4)}