Don't add nonfunctional proxyconfig plugins in the Settings dialog

Bitmessage · Jul 2, 2021 · a9488fb · a9488fb
1 parent 5fa8115
commit a9488fb
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/bitmessageqt/settings.py b/src/bitmessageqt/settings.py
@@ -57,9 +57,16 @@ def __init__(self, parent=None, firstrun=False):
             pass
         else:
             # Append proxy types defined in plugins
+            # FIXME: this should be a function in mod:`plugin`
             for ep in pkg_resources.iter_entry_points(
                     'bitmessage.proxyconfig'):
-                self.comboBoxProxyType.addItem(ep.name)
+                try:
+                    ep.load()
+                except Exception:  # it should add only functional plugins
+                    # many possible exceptions, which are don't matter
+                    pass
+                else:
+                    self.comboBoxProxyType.addItem(ep.name)
 
         self.lineEditMaxOutboundConnections.setValidator(
             QtGui.QIntValidator(0, 8, self.lineEditMaxOutboundConnections))