Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WB compatibility issue #288

Closed
webbird opened this issue Feb 5, 2015 · 1 comment
Closed

WB compatibility issue #288

webbird opened this issue Feb 5, 2015 · 1 comment
Assignees
@webbird
Labels
bug ready
Milestone
v1.1.1

Comments

@webbird
Copy link
Contributor

webbird commented Feb 5, 2015

I just encountered a compatibility issue with function load_module located in framework\functions.php. This is now a wrapper around CAT_Helper_Addons::installModule(). But while load_module expects a directory name as first param, installModule() expects the name of a zip file.

Within BC this is no problem as we use the helper, but if an old WB module calls load_module(), one gets an 'invalid zip file` error; in addition, the module folder gets deleted after this error. (!)

Found this when trying to install "OneForAll".
@webbird webbird self-assigned this Feb 5, 2015
@webbird webbird added this to the v1.1.1 milestone Feb 5, 2015
webbird pushed a commit that referenced this issue Feb 5, 2015
fix for issue #288
9c0a003
@webbird webbird added the ready label Feb 5, 2015
@webbird
Copy link
Contributor Author

webbird commented Mar 9, 2015

Closed with release 1.1.1.

@webbird webbird closed this as completed Mar 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@webbird webbird

Labels
bug ready
Projects
None yet
Milestone
v1.1.1
Development

No branches or pull requests
1 participant
@webbird