Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addons Catalog: Unable to install modules with tag only #343

Closed
webbird opened this issue Jun 15, 2016 · 0 comments
Closed

Addons Catalog: Unable to install modules with tag only #343

webbird opened this issue Jun 15, 2016 · 0 comments
Assignees
@webbird
Labels
bug ready
Milestone
v1.2.2

Comments

@webbird
Copy link
Contributor

webbird commented Jun 15, 2016

GitHub will not return any release data if there is only a tag with no release info (button [Draft release]). The ajax_catalog_install.php does a fallback to get the tags then, but there are two errors:

  • count() on wrong array
  • $tags is a multidimensional array, so $tags['zipball_url'] is wrong
@webbird webbird added the bug label Jun 15, 2016
@webbird webbird added this to the v1.2.2 milestone Jun 15, 2016
@webbird webbird self-assigned this Jun 15, 2016
webbird pushed a commit that referenced this issue Jun 15, 2016
fix for issue #343
d6b31a0
@webbird webbird added the ready label Jun 15, 2016
@webbird webbird closed this as completed Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@webbird webbird

Labels
bug ready
Projects
None yet
Milestone
v1.2.2
Development

No branches or pull requests
1 participant
@webbird