Skip to content

Commit

Permalink
fix: select element not working on Windows (electron#29742)
Browse files Browse the repository at this point in the history
  • Loading branch information
codebytere authored and BlackHole1 committed Aug 27, 2021
1 parent c1084e2 commit adc9427
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions patches/chromium/extend_apply_webpreferences.patch
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Ideally we could add an embedder observer pattern here but that can be
done in future work.

diff --git a/third_party/blink/renderer/core/exported/web_view_impl.cc b/third_party/blink/renderer/core/exported/web_view_impl.cc
index b627f400d16ee1c605ef7657dc3ba63319c5fd56..455b0fd461d0c32de39800d4d7cef2ceb30dc7fb 100644
index b627f400d16ee1c605ef7657dc3ba63319c5fd56..72f7e877a9601f7b2277d109aaae13eda4277076 100644
--- a/third_party/blink/renderer/core/exported/web_view_impl.cc
+++ b/third_party/blink/renderer/core/exported/web_view_impl.cc
@@ -155,6 +155,7 @@
Expand All @@ -23,7 +23,15 @@ index b627f400d16ee1c605ef7657dc3ba63319c5fd56..455b0fd461d0c32de39800d4d7cef2ce
#include "third_party/blink/renderer/platform/graphics/image.h"
#include "third_party/blink/renderer/platform/graphics/paint/cull_rect.h"
#include "third_party/blink/renderer/platform/graphics/paint/paint_record_builder.h"
@@ -1792,6 +1793,16 @@ void WebView::ApplyWebPreferences(const web_pref::WebPreferences& prefs,
@@ -1784,6 +1785,7 @@ void WebView::ApplyWebPreferences(const web_pref::WebPreferences& prefs,
#if defined(OS_MAC)
web_view_impl->SetMaximumLegibleScale(
prefs.default_maximum_page_scale_factor);
+ SetUseExternalPopupMenus(!prefs.offscreen);
#endif

#if defined(OS_WIN)
@@ -1792,6 +1794,14 @@ void WebView::ApplyWebPreferences(const web_pref::WebPreferences& prefs,

RuntimeEnabledFeatures::SetTranslateServiceEnabled(
prefs.translate_service_available);
Expand All @@ -35,8 +43,6 @@ index b627f400d16ee1c605ef7657dc3ba63319c5fd56..455b0fd461d0c32de39800d4d7cef2ce
+ color = static_cast<SkColor>(blink_color);
+ }
+ web_view->SetBaseBackgroundColor(color);
+
+ SetUseExternalPopupMenus(!prefs.offscreen);
}

void WebViewImpl::ThemeChanged() {

0 comments on commit adc9427

Please sign in to comment.