release 1.2.3 for fix bug of autoDetect

BlackToolBoxLaboratory · Dec 13, 2020 · 28d9f13 · 28d9f13
1 parent 6ee9cf4
commit 28d9f13
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 11 deletions.
diff --git a/CHANGELOGS.md b/CHANGELOGS.md
@@ -1,3 +1,9 @@
+## v1.2.3
+
+> Dec, 13, 2020
+
+- **Issue**: Fix bug of autoDetect.
+
 ## v1.2.2
 
 > Sep, 12, 2020

diff --git a/module/components/Popover.jsx b/module/components/Popover.jsx
@@ -26,10 +26,10 @@ const Popover = React.forwardRef((props, ref) => {
   useEffect(() => {
     _resize();
     window.addEventListener('resize', _resize);
-    window.addEventListener('scroll', _scroll);
+    window.addEventListener('scroll', _resize);
     return function cleanup() {
       window.removeEventListener('resize', _resize);
-      window.removeEventListener('scroll', _scroll);
+      window.removeEventListener('scroll', _resize);
     };
   }, []);
 
@@ -65,14 +65,6 @@ const Popover = React.forwardRef((props, ref) => {
       });
     }
   }
-  function _scroll() {
-    if (env.autoDetect) {
-      env.state_autoAdjust.onAdjust({
-        ...env.state_autoAdjust.value,
-        ..._detectY()
-      });
-    }
-  }
 
   function _clickListener (event) {
     let result = event.composedPath().find((node) => {

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@blacktoolbox/react-popover",
   "packageName": "btblab-react-popover",
-  "version": "1.2.2",
+  "version": "1.2.3",
   "description": "Popover maker based on React",
   "keywords": [
     "blacktoolbox",