Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Byte Vec Deserialize Wrapper #68

Merged
merged 14 commits into from Dec 10, 2020

Conversation

unizippro
Copy link
Contributor

Wrapper for deserializing a Vector of bytes like fx "+UUWLE:32AB6A7A4044".
Primarily done to parse bssid for ublox-short-range-rs.
But this is kind of a catch all for any Non comma separated value in any AT command.

Copy link
Member

@MathiasKoch MathiasKoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes, but overall looks good.

serde_at/src/de/mod.rs Show resolved Hide resolved
serde_at/src/de/seq.rs Show resolved Hide resolved
serde_at/src/de/mod.rs Outdated Show resolved Hide resolved
serde_at/src/de/mod.rs Outdated Show resolved Hide resolved
serde_at/src/de/seq.rs Show resolved Hide resolved
serde_at/src/de/mod.rs Outdated Show resolved Hide resolved
serde_at/src/de/mod.rs Outdated Show resolved Hide resolved
@unizippro
Copy link
Contributor Author

Tarpaulin is crashing and i have no clue why this is the case.
Anyone who can offer any advice or help would be greatly appreciated!

@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #68 (947e25e) into master (63e4524) will increase coverage by 1.02%.
The diff coverage is 67.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage   31.36%   32.39%   +1.02%     
==========================================
  Files          20       20              
  Lines        1065     1096      +31     
==========================================
+ Hits          334      355      +21     
- Misses        731      741      +10     
Impacted Files Coverage Δ
serde_at/src/lib.rs 100.00% <ø> (ø)
serde_at/src/de/mod.rs 64.66% <62.50%> (-0.42%) ⬇️
serde_at/src/de/seq.rs 80.00% <85.71%> (+3.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63e4524...947e25e. Read the comment docs.

@MathiasKoch MathiasKoch merged commit 3129a22 into master Dec 10, 2020
@MathiasKoch MathiasKoch deleted the feature/byte_vec_deserialize branch December 10, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants