Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XCFramework Compatibility #34

Merged
merged 2 commits into from
May 20, 2021
Merged

XCFramework Compatibility #34

merged 2 commits into from
May 20, 2021

Conversation

Blackjacx
Copy link
Owner

Changes

  • Allows the framework to be built with Carthage 0.38.0 using the command line carthage build --platform iOS --cache-builds --use-xcframeworks as xcframework and to be integrated in your project
  • Rename Main class Columbus > ColumbusMain
  • Update Copyrights
  • Resolve Xcode recommended warnings

Rename Main class Columbus > ColumbusMain
This was necessary to establish compatibility with XCFrameworks. See
https://forums.swift.org/t/frameworkname-is-not-a-member-type-of-frameworkname-errors-inside-swiftinterface/28962
@Blackjacx Blackjacx self-assigned this May 20, 2021
@github-actions
Copy link

1 Warning
⚠️ There're app changes, but not tests. That's OK as long as you're refactoring existing code.

Generated by 🚫 Danger

@Blackjacx Blackjacx merged commit 27cfb92 into develop May 20, 2021
@Blackjacx Blackjacx deleted the xcframework-compatibility branch May 20, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant