Improve Makefiles. #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use CXX instead of CC and CXXFLAGS instead of CFLAGS for C++. - Remove LD, because it is set to the same value as CXX. - Don't overwrite CXX and CXXFLAGS if they are set as environment variables. - Replace calls to: - g++ with $(CXX) - gcc with $(CC) - ar with $(AR) See <https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html>.
gentoo-bot
pushed a commit
to gentoo/guru
that referenced
this pull request
May 3, 2021
Changes proposed upstream: <Blackvoxel/Blackvoxel#35>. Closes: https://bugs.gentoo.org/787074 Signed-off-by: Ronny (tastytea) Gutbrod <gentoo@tastytea.de>
|
Hello Tastytea, Thanks for submitting this good fix. We'll review it quickly. It should be merged in the next days. Thanks for your interest in our game and for your work. |
The value of $(MAKE) is the file name with which make was invoked. This also ensures that the environment variable MAKEFLAGS is passed down.
|
I've added a commit to replace calls to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
variables.
See https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html.
Hardcoding tools can cause issues with cross-compiling and make it impossible to use a different compiler. Overwriting CXXFLAGS prevents me from adding additional compiler-flags (like
-march=native).