-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow BRJS to be run from outside of the SDK directory by putting brjs on the PATH #1130
Comments
@andyberry88, are we going to move this out of |
I've created a separate issue (#1154) to track the separation of the SDK and apps. This issue is only to allow BRJS to be run from outside of the |
This was mostly already possible. Only the legacy test runner needed changing - see PR #1172. It's now possible to do the following:
|
tested. works on windows + also when integrated with CT. tested a multitude of commands: test, serve, help, export-app... |
I suspect its already possible to run BRJS from anywhere but it needs verifying.
We already pass the location of BRJS to the model via command line args (added by the
brjs
script) so if we started adding the current working directory that should allow us to both allow BRJS to run from anywhere and apps to live separately from BRJS.This includes #93 and #95 which have been closed and tracked as a subtask of #1. We hadn't originally planned to do this work for 1.0 but it seems that it would be much more beneficial and sought after than context aware commands (#885), which we had planned to do, and would take a lot less dev effort.
The text was updated successfully, but these errors were encountered: