Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Possible wrong calculations for Stock Flow Records #1370

Closed
josephelkhoury opened this issue Mar 8, 2023 · 4 comments
Closed

[Issue] Possible wrong calculations for Stock Flow Records #1370

josephelkhoury opened this issue Mar 8, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@josephelkhoury
Copy link
Contributor

Describe the bug
I guess the calculations are wrong when you try to Void an order with a refund and return products.
Then when you do a delete on the order.

To Reproduce
On void it does a proper stock update. But if you delete the order, it does an additional update to the inventory.

Expected behavior
If the stock was updated on order void and return, it shouldn't update again when we delete the order.

Environment:

  • NexoPOS 4.8.15
@Blair2004 Blair2004 added the bug Something isn't working label Mar 10, 2023
@Blair2004 Blair2004 self-assigned this Mar 10, 2023
@Blair2004
Copy link
Owner

Thanks for reporting we're reviewing.

@Blair2004
Copy link
Owner

Hi,
We're curious. How do you void a partially refunded order ? We're not able to do that.
Let us know.

@josephelkhoury
Copy link
Contributor Author

josephelkhoury commented Mar 12, 2023

Hey,

I can't void a partially refunded order.

Scenario:
You have 15 bottles of water in your stock.
You create a new order and sell 3 bottles.
Stock is now 12.

Go to orders and void the order you just made.
Stock is now back to 15.
Go to orders and delete the same order you just voided.
Stock is now 18.

@Blair2004
Copy link
Owner

Blair2004 commented Mar 12, 2023 via email

nexopos pushed a commit that referenced this issue Mar 12, 2023
- Fixed: Duplicate stock return on Void and Delete actions (#1370)
- Fixed: Improved Printing Options (#1361,#1359,#1346)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants