Adds keyboard support to payment popup #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blair2004
reviewed
Oct 13, 2022
Blair2004
reviewed
Oct 15, 2022
| nsHotPress | ||
| .create( 'numpad-save' ) | ||
| .whenVisible([ '.is-popup' ]) | ||
| .whenPressed( 'enter', () => this.inputValue({ identifier: 'next' })) |
There was a problem hiding this comment.
We should allow users to submit payment using the "Enter" key. This will assume, on first press if the amount is different from "0", we'll add it as a payment and set the visible amount to "0". On the second press when the amount is "0" we'll emit a "submit" event to the parent component.
Blair2004
approved these changes
Oct 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.