POC #4
Open
POC #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h1alexbel
reviewed
Jun 3, 2023
| <artifactId>spring-boot-starter-parent</artifactId> | ||
| <version>3.0.6</version> | ||
| <relativePath/> | ||
| <!-- lookup parent from repository --> |
There was a problem hiding this comment.
@l3r8yJ remove the comments please
| <groupId>io.netty</groupId> | ||
| <artifactId>netty-resolver-dns-native-macos</artifactId> | ||
| <version>${netty-resolver-dns-native-macos.version}</version> | ||
| <classifier>osx-aarch_64</classifier> |
There was a problem hiding this comment.
@l3r8yJ why do we need this dependency?
There was a problem hiding this comment.
@h1alexbel netty doesn't work without it on m1 cpu
| import lombok.extern.slf4j.Slf4j; | ||
| import org.springframework.http.HttpStatus; | ||
| import org.springframework.http.MediaType; | ||
| import org.springframework.web.bind.annotation.*; |
There was a problem hiding this comment.
@l3r8yJ remove wildcard import
h1alexbel
reviewed
Jun 3, 2023
| .map( | ||
| usr -> | ||
| this.webClient.post() | ||
| .uri("/api/v1/bot/updates") |
There was a problem hiding this comment.
@l3r8yJ I think we can transfer messages to the hub initially
then from hub, we grooming the notifications and resend them to the bot
WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@h1alexbel take a look, please
part of POC
PR-Codex overview
This PR adds functionality for Blamer Notifications, a service that transfers GitHub notifications into text notifications for Telegram. It includes changes to configuration files, test files, and several Java classes.
Detailed summary
base-urlandporttoapplication-dev.yamlmvn.yamlto includejava: [ 17, 20 ]portandrsockettoapplication.yamlcodecov.yamlwith a to-do commentLICENSE.txtwith a new copyright holder nameREADME.mdwith a new logo and updated informationTelegramUserandUpdateMessageclassesNotificationsAppEntryclassExtWebClientclass