failing example of updating views with inheritance

The error is "The update operation did not return the expected update count". Disabling static implementation scanning (uncomment in createEntityViewManager) fixes the issue.
Blazebit · Feb 9, 2023 · 71fb665 · 71fb665
1 parent fdd7394
commit 71fb665
Show file tree

Hide file tree

Showing 7 changed files with 155 additions and 1 deletion.
diff --git a/examples/spring-data-spqr/pom.xml b/examples/spring-data-spqr/pom.xml
@@ -198,6 +198,12 @@
             <artifactId>jakarta.annotation-api</artifactId>
             <version>${version.annotation}</version>
         </dependency>
+        <dependency>
+            <groupId>${project.groupId}</groupId>
+            <artifactId>blaze-persistence-entity-view-processor</artifactId>
+            <version>${project.version}</version>
+            <scope>provided</scope>
+        </dependency>
     </dependencies>
 
     <build>
@@ -221,6 +227,72 @@
                     </execution>
                 </executions>
             </plugin>
+            <plugin>
+                <groupId>org.bsc.maven</groupId>
+                <artifactId>maven-processor-plugin</artifactId>
+                <executions>
+                    <execution>
+                        <id>process</id>
+                        <goals>
+                            <goal>process</goal>
+                        </goals>
+                        <phase>generate-sources</phase>
+                        <configuration>
+                            <!-- source output directory -->
+                            <outputDirectory>${project.build.directory}/metamodel</outputDirectory>
+                            <processors>
+                                <processor>com.blazebit.persistence.view.processor.EntityViewAnnotationProcessor</processor>
+                            </processors>
+                        </configuration>
+                    </execution>
+                </executions>
+                <dependencies>
+                    <!-- Metamodel -->
+                    <dependency>
+                        <groupId>${project.groupId}</groupId>
+                        <artifactId>blaze-persistence-entity-view-processor</artifactId>
+                        <version>${project.version}</version>
+                    </dependency>
+                    <dependency>
+                        <groupId>jakarta.xml.bind</groupId>
+                        <artifactId>jakarta.xml.bind-api</artifactId>
+                        <version>${version.jaxb-api}</version>
+                    </dependency>
+                    <dependency>
+                        <groupId>com.sun.xml.bind</groupId>
+                        <artifactId>jaxb-impl</artifactId>
+                        <version>${version.jaxb}</version>
+                    </dependency>
+                    <dependency>
+                        <groupId>jakarta.transaction</groupId>
+                        <artifactId>jakarta.transaction-api</artifactId>
+                        <version>${version.jta}</version>
+                    </dependency>
+                    <dependency>
+                        <groupId>jakarta.activation</groupId>
+                        <artifactId>jakarta.activation-api</artifactId>
+                        <version>${version.activation}</version>
+                    </dependency>
+                </dependencies>
+            </plugin>
+            <plugin>
+                <groupId>org.codehaus.mojo</groupId>
+                <artifactId>build-helper-maven-plugin</artifactId>
+                <executions>
+                    <execution>
+                        <id>add-source-metamodel</id>
+                        <phase>generate-sources</phase>
+                        <goals>
+                            <goal>add-source</goal>
+                        </goals>
+                        <configuration>
+                            <sources>
+                                <source>${project.build.directory}/metamodel</source>
+                            </sources>
+                        </configuration>
+                    </execution>
+                </executions>
+            </plugin>
         </plugins>
     </build>
 </project>
diff --git a/.../blazebit/persistence/examples/spring/data/spqr/config/BlazePersistenceConfiguration.java b/.../blazebit/persistence/examples/spring/data/spqr/config/BlazePersistenceConfiguration.java
@@ -57,6 +57,7 @@ public CriteriaBuilderFactory createCriteriaBuilderFactory() {
     @Scope(ConfigurableBeanFactory.SCOPE_SINGLETON)
     @Lazy(false)
     public EntityViewManager createEntityViewManager(CriteriaBuilderFactory cbf, EntityViewConfiguration entityViewConfiguration) {
+//        entityViewConfiguration.getProperties().setProperty("com.blazebit.persistence.view.static_implementation_scanning_disabled", "true");
         return entityViewConfiguration.createEntityViewManager(cbf);
     }
 }
diff --git a/.../main/java/com/blazebit/persistence/examples/spring/data/spqr/resource/CatGraphQLApi.java b/.../main/java/com/blazebit/persistence/examples/spring/data/spqr/resource/CatGraphQLApi.java
@@ -19,6 +19,9 @@
 import com.blazebit.persistence.examples.spring.data.spqr.repository.CatViewRepository;
 import com.blazebit.persistence.examples.spring.data.spqr.view.CatCreateView;
 import com.blazebit.persistence.examples.spring.data.spqr.view.CatWithOwnerView;
+import com.blazebit.persistence.examples.spring.data.spqr.view.ChildInput;
+import com.blazebit.persistence.examples.spring.data.spqr.view.ChildView;
+import com.blazebit.persistence.examples.spring.data.spqr.view.PersonSimpleView;
 import com.blazebit.persistence.integration.graphql.GraphQLEntityViewSupport;
 import com.blazebit.persistence.view.EntityViewManager;
 import com.blazebit.persistence.view.EntityViewSetting;
@@ -76,4 +79,13 @@ public Long createCat(@GraphQLArgument(name = "cat") CatCreateView cat) {
         repository.save(cat);
         return cat.getId();
     }
+
+    @GraphQLMutation
+    public Long addPersonChild(@GraphQLArgument(name = "child") ChildInput childInput, @GraphQLArgument(name = "personId") Long personId) {
+        PersonSimpleView person = repository.findById(EntityViewSetting.create(PersonSimpleView.class), personId);
+        ChildView child = (childInput.getBoy() != null) ? childInput.getBoy() : childInput.getGirl();
+        person.getChildren().add(child);
+        repository.save(person);
+        return child.getId();
+    }
 }
diff --git a/...pqr/src/main/java/com/blazebit/persistence/examples/spring/data/spqr/view/ChildInput.java b/...pqr/src/main/java/com/blazebit/persistence/examples/spring/data/spqr/view/ChildInput.java
@@ -0,0 +1,45 @@
+/*
+ * Copyright 2014 - 2023 Blazebit.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.blazebit.persistence.examples.spring.data.spqr.view;
+
+import io.leangen.graphql.annotations.types.GraphQLType;
+
+/**
+ * @author Christian Beikov
+ * @since 1.6.4
+ */
+@GraphQLType(name = "ChildInput")
+public class ChildInput {
+    BoyView boy;
+    GirlView girl;
+
+    public BoyView getBoy() {
+        return boy;
+    }
+
+    public void setBoy(BoyView boy) {
+        this.boy = boy;
+    }
+
+    public GirlView getGirl() {
+        return girl;
+    }
+
+    public void setGirl(GirlView girl) {
+        this.girl = girl;
+    }
+}
diff --git a/...spqr/src/main/java/com/blazebit/persistence/examples/spring/data/spqr/view/ChildView.java b/...spqr/src/main/java/com/blazebit/persistence/examples/spring/data/spqr/view/ChildView.java
@@ -17,6 +17,7 @@
 package com.blazebit.persistence.examples.spring.data.spqr.view;
 
 import com.blazebit.persistence.examples.spring.data.spqr.model.Child;
+import com.blazebit.persistence.view.CreatableEntityView;
 import com.blazebit.persistence.view.EntityView;
 import com.blazebit.persistence.view.EntityViewInheritance;
 import com.blazebit.persistence.view.IdMapping;
@@ -26,7 +27,9 @@
  * @author Christian Beikov
  * @since 1.6.4
  */
-@GraphQLUnion(name = "Child", possibleTypeAutoDiscovery = true)
+// Can't use possibleTypeAutoDiscovery=true because of the generated EV implementations
+@GraphQLUnion(name = "Child", possibleTypes = {BoyView.class, GirlView.class})
+@CreatableEntityView
 @EntityView(Child.class)
 @EntityViewInheritance
 public interface ChildView {
@@ -35,4 +38,6 @@ public interface ChildView {
     Long getId();
 
     String getName();
+
+    void setName(String name);
 }
diff --git a/...c/main/java/com/blazebit/persistence/examples/spring/data/spqr/view/PersonSimpleView.java b/...c/main/java/com/blazebit/persistence/examples/spring/data/spqr/view/PersonSimpleView.java
@@ -18,13 +18,15 @@
 
 import com.blazebit.persistence.examples.spring.data.spqr.model.Person;
 import com.blazebit.persistence.view.EntityView;
+import com.blazebit.persistence.view.UpdatableEntityView;
 
 import java.util.Set;
 
 /**
  * @author Christian Beikov
  * @since 1.6.4
  */
+@UpdatableEntityView
 @EntityView(Person.class)
 public interface PersonSimpleView extends PersonIdView {
 

diff --git a/...c/test/java/com/blazebit/persistence/examples/spring/data/spqr/repository/SampleTest.java b/...c/test/java/com/blazebit/persistence/examples/spring/data/spqr/repository/SampleTest.java
@@ -31,6 +31,7 @@
 import java.util.List;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNull;
 
 /**
  * @author Christian Beikov
@@ -106,6 +107,22 @@ public void testCreate() {
         assertEquals("PersonSimpleView", response.getBody().get("data").get("catById").get("owner").get("__typename").asText());
     }
 
+    @Test
+    public void testCreateInheritance() {
+        String requestGraphQL = "mutation {\n" +
+                "  addPersonChild(\n" +
+                "    child: {\n" +
+                "      boy: { name: \"Test\" }\n" +
+                "    },\n" +
+                "    personId: 3\n" +
+                "  )\n" +
+                "}";
+        HttpHeaders headers = new HttpHeaders();
+        headers.add("content-type", "application/graphql");
+        ResponseEntity<JsonNode> response = this.restTemplate.postForEntity("/graphql", new HttpEntity<>(requestGraphQL, headers), JsonNode.class);
+        assertNull(response.getBody().get("errors"));
+    }
+
     static String request(int first, String after) {
         String other = "";
         if (after != null) {