DE478702 revert #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dberstein
suggested changes
Sep 22, 2020
src/Mongator/Extension/Core.php
Outdated
| @@ -1148,7 +1148,7 @@ private function parseAndCheckAssociationClass(&$association, $name) | |||
|
|
|||
| private function mapArrayKeyWithDefault($array, $key, array $mapCallback, $default) | |||
| { | |||
| if (property_exists($array, $key)) { | |||
| if (array_key_exists($key, $array)) { | |||
There was a problem hiding this comment.
What was deprecated was usage on objects, not arrays, thus this may help:
if ((is_array($array) && array_key_exists($key, $array)) || (is_object($array) && property_exists($array::class, $key))) {
There was a problem hiding this comment.
@dberstein what about simply isSet($array[$key]) - didn't you say that fixes it? and it is a bit cleaner
There was a problem hiding this comment.
@ymalen isset is not clear enough, if mixes key exists and non-nullness of value. On the other hand array_key_exists does exactly that: it tells if a key exists, regardless of its value.
There was a problem hiding this comment.
Simplified example where key exists (key "null") and isset != array_key_exists:
$ php --version; php -r '$a=["null"=>null]; var_dump(isset($a["null"]), array_key_exists("null", $a));'
PHP 7.4.10 (cli) (built: Sep 3 2020 18:19:30) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
with Xdebug v2.9.7, Copyright (c) 2002-2020, by Derick Rethans
with Zend OPcache v7.4.10, Copyright (c), by Zend Technologies
Command line code:1:
bool(false)
Command line code:1:
bool(true)
dberstein
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.