Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US47068 fixed disconnect for socketio.Client. Fixes stuck taurus sess… #1718

Merged
merged 1 commit into from May 3, 2023

Conversation

jaroslavlibak
Copy link
Contributor

@jaroslavlibak jaroslavlibak commented May 3, 2023

  • socketio.Client has a bug when it cannot shut down its resources when SocketIO connection has been established and then lost. It results in reconnect thread that is not shut down and causes stuck taurus sessions
  • reworked connect and logging when unable to send metrics
  • verified locally when happysocks is repeatedly started and stopped with both on and off at the end of taurus session

@jaroslavlibak jaroslavlibak self-assigned this May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #1718 (f257cf9) into master (623297c) will decrease coverage by 0.02%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #1718      +/-   ##
==========================================
- Coverage   89.62%   89.60%   -0.02%     
==========================================
  Files          70       70              
  Lines       18557    18568      +11     
==========================================
+ Hits        16630    16636       +6     
- Misses       1927     1932       +5     
Impacted Files Coverage Δ
bzt/modules/blazemeter/blazemeter_reporter.py 92.11% <50.00%> (-0.75%) ⬇️
bzt/bza.py 87.42% <100.00%> (-0.10%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@matus-gazo matus-gazo merged commit 171de44 into master May 3, 2023
1 of 3 checks passed
@matus-gazo matus-gazo deleted the US47068-happysocks-stuck-sessions branch May 3, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants