Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JavaScript interop to new spec #11

Closed
danielmeza opened this issue Jul 26, 2018 · 5 comments
Closed

Update JavaScript interop to new spec #11

danielmeza opened this issue Jul 26, 2018 · 5 comments
Assignees
@galvesribeiro
Labels
enhancement New feature or request

Comments

@danielmeza
Copy link

Hi @galvesribeiro this is for track the update to new interop spec
@galvesribeiro galvesribeiro self-assigned this Jul 26, 2018
@galvesribeiro
Copy link
Member

Thanks!

I'm working on it.

Will let you know here soon.

@galvesribeiro galvesribeiro added the enhancement New feature or request label Jul 26, 2018
@danielmeza
Copy link
Author

Great! do you acept more forkers?

@danielmeza
Copy link
Author

@galvesribeiro I made a PR #12

@galvesribeiro
Copy link
Member

Thanks for the PR! I'll review it when I get to the SignalR component. Working on the others now.

Thanks!

@galvesribeiro
Copy link
Member

galvesribeiro commented Jul 28, 2018 •
edited
Loading

Hello @danielmeza! As I mentioned on the PR here, I decided to use the new non-static interop mode and that goes totally different from the way the code was and your PR as well so I close it.

The final changes are on this commit: 4194f50

Again, thank you very much for the PR, I really appreciate that, and looking forward for other contributions!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galvesribeiro galvesribeiro

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@galvesribeiro @danielmeza