Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use the new JavaScript Interop spec. #12

Closed
wants to merge 1 commit into from

Conversation

danielmeza
Copy link

@danielmeza danielmeza commented Jul 26, 2018

All methods work and avoid breacking changes.
@attilah @galvesribeiro

@galvesribeiro
Copy link
Member

Hello @danielmeza thank you very much for your PR.

It worked perfectly!

However, I decided to drop the usage of the static interop mode in favor of the new non-static/instance mode and that made me rewrite a lot of code and for that reason it made me not merge this and rather keep my changes.

Please don't see it as a means of judge badly your PR. The code was perfect, that changes worked, everything is fine. I just did that so I could easily unblock myself with the other changes.

Please feel free to submit any other PR you feel necessary and we will evaluate it.

Again, thank you very much for your time! I hope to see other contributions from you soon!

@galvesribeiro galvesribeiro self-assigned this Jul 28, 2018
@galvesribeiro galvesribeiro added the wontfix This will not be worked on label Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants