-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Blazor 3.0.0-preview6 #35
Conversation
theprateik
commented
Jun 19, 2019
- Update global.json to reflect the updated sdk version
- Replace Json.Deserialize by JsonSerializer.Parse in class HubConnection
- Add this. where missing in class HubConnection
- Replace onclick and bind attributes in test razor pages by @OnClick and @Bind
- Replace @functions by @code in test razor files
- Remove UseSignalR and UseBlazor from test Server Startup class Configure method
- Add UseAuthorization to Startup class
- Comment out AddMessagePackProtocol and uncommented AddJsonProtocol in Startup class
- Comment out AddMessagePackProtocol in ChatComponent class
- Update global.json to reflect the updated sdk version - Replace Json.Deserialize by JsonSerializer.Parse in class HubConnection - Add this. where missing in class HubConnection - Replace onclick and bind attributes in test razor pages by @OnClick and @Bind - Replace @functions by @code in test razor files - Remove UseSignalR and UseBlazor from test Server Startup class Configure method - Add UseAuthorization to Startup class - Comment out AddMessagePackProtocol and uncommented AddJsonProtocol in Startup class - Comment out AddMessagePackProtocol in ChatComponent class
Not sure why the check is failing. But there is one issue though, that i noticed. |
I found out that system.text.json don't support some certain datatypes yet as far I have been researched. I think bytes array is one of these datatypes that system.text.json doesn't fully support without converting the datatype into a string which is json, however, that will fail on the I have tried to clone the project and tried to make the same setup except that I am using newtonsoft.json instead of system.text.json because it does support many datatypes. I am using worth mentioning: however, I am not sure if it is a bad idea to use newtonsoft.json instead of system.text.json and I hope that that you can give your thoughts on this. What do you think? |
Hello! Could you please fix the build issue? Its been a while and the build doesn't have the history anymore so I can't check the problem. |
There is no issue in building this locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fix the CI scripts and we're good to go! Thanks!
@galvesribeiro, thanks. I will try that and submit soon. |
@galvesribeiro, fixed the CI scripts. |
@djinnet, it seems .NET Core development team is pushing on |
I would stick with the new JSON stuff. The official SignalR client and the Hub uses it by default now, so I wouldn't move the other way around specially that now we're talking about javascript interop in this particular case. If we ever come to make this "native" in C# only, perhaps we could add the right abstraction... |
@theprateik thank YOU so much for the PR! Will publish the package soon! |
* fix example for injected HubConnectionBuilder (#28) * Update to Blazor 3.0.0-preview6 (#35) * Update to Blazor 3.0.0-preview6 - Update global.json to reflect the updated sdk version - Replace Json.Deserialize by JsonSerializer.Parse in class HubConnection - Add this. where missing in class HubConnection - Replace onclick and bind attributes in test razor pages by @OnClick and @Bind - Replace @functions by @code in test razor files - Remove UseSignalR and UseBlazor from test Server Startup class Configure method - Add UseAuthorization to Startup class - Comment out AddMessagePackProtocol and uncommented AddJsonProtocol in Startup class - Comment out AddMessagePackProtocol in ChatComponent class * Update .vsts-ci.yml and .vsts-release.yml to use the .NET Core Preview 6 SDK.