Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign assembly with Strong Name Key #133

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Conversation

pmachapman
Copy link
Contributor

Added a strong name key file, and signed the assembly with it.

This resolves the warning CS8002: Referenced assembly 'Blazored.LocalStorage, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' does not have a strong name. when referencing this assembly from another strong name key signed assembly (#127).

As per guidance at https://github.com/dotnet/runtime/blob/main/docs/project/strong-name-signing.md, the key has been checked into the repository:

we would recommend that these open source projects check-in their private key

@chrissainty chrissainty added the Feature New feature that will be added to the project label Apr 21, 2021
Copy link
Member

@chrissainty chrissainty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for this @pmachapman 👍

@chrissainty chrissainty merged commit d2c1829 into Blazored:main Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature that will be added to the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants