Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for LocalStorage configuration, initially for JsonSerializerOptions #81

Merged
merged 4 commits into from
May 21, 2020
Merged

Added support for LocalStorage configuration, initially for JsonSerializerOptions #81

merged 4 commits into from
May 21, 2020

Conversation

jan-johansson-mr
Copy link
Contributor

Hi,

I've added support for tweaking json serializer options for LocalStorage. I've updated the tests for the change of the code. Please review and you're welcome with any feedback.

Thanks,
//Jan

@jan-johansson-mr
Copy link
Contributor Author

jan-johansson-mr commented May 20, 2020

Hi,

I've let the type of the object that is to be serialized to be exposed to the serializer (from the former behavior when 'object' was passed to the serializer). The reason for this is that I have a converter that actually is triggered by the type in the graph to be serialized, the passing of 'object' doesn't trigger my converter. The change will not break existing code, so the change is seamless. Please check it out

Thanks,
//Jan

Copy link
Member

@chrissainty chrissainty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here @jan-johansson-mr. The only bit that's missing is some documentation in the readme. If you could add that then we can get this merged.

@@ -6,7 +6,7 @@
<RootNamespace>Blazored.LocalStorage</RootNamespace>

<PackageId>Blazored.LocalStorage</PackageId>
<Version>2.1.5</Version>
<Version>2.1.6-preview-0.0.2</Version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you undo this one? We set the build number when this goes to release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems :-)

@jan-johansson-mr
Copy link
Contributor Author

Added documentation and reverted version tag in project file

@jan-johansson-mr
Copy link
Contributor Author

Hey,

I've ripped off your amazing LocalStorage and created SessionStorage. Please take a look and I'd be happy if you included this derivative work alongside with LocalStorage.

Thanks,
//Jan

@chrissainty
Copy link
Member

chrissainty commented May 21, 2020

Hi Jan, there is already Blazored Session Storage. It would be great if you want to contribute to that project and add in the same improvements rather than start a whole new fork.

@jan-johansson-mr
Copy link
Contributor Author

jan-johansson-mr commented May 21, 2020

Oh, I missed that one, since it was not pinned :-) Thanks!
Will work on that too... so brace for update real soon :-)

@chrissainty chrissainty merged commit d714c01 into Blazored:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants