From Version 2.x to 3.0

[JAzevedoDev]

Hello
In version 2.x

Public static void OpenPage(string pageName, dynamic rec,IModalService modalService, Action<string, dynamic> action, string group = "std")
        {
                string MyPageName = $"MyProject.Pages.{group}.Pages." + pageName;
                Type MYTYPE = Type.GetType(MyPageName);
                ModalParameters ModalParams = new ModalParameters();
                ModalParams.Add("RecRef", rec);
                ModalParams.Add("executeOnValidate", action);
                ModalParams.Add("isModal", true);
                modalService.Show(pageName, MYTYPE, ModalParams);
        }

And in 3.0 this dont work anymore because i need to to include Show<MyProject.Pages.std.Pages.MYPAGE> but i cant use the MYTYPE like this: modal.Show(...)

Public static void OpenPage(string pageName, dynamic rec,IModalService modalService, Action<string, dynamic> action, string group = "std")
        {
                string MyPageName = $"MyProject.Pages.{group}.Pages." + pageName;
                Type MYTYPE = Type.GetType(MyPageName);
                ModalParameters ModalParams = new ModalParameters();
                ModalParams.Add("RecRef", rec);
                ModalParams.Add("executeOnValidate", action);
                ModalParams.Add("isModal", true);
                modalService.Show<MYTYPE>(pageName, ModalParams);
        }

[larsk2009]

You are right that you cannot do what you did in v2.x anymore in v3.x unless I am missing something. The v3.x function is using generics. The compiler needs to be able to infer the type at compile-time, which is not possible when using a variable for the type.

I can see this was changed by @chrissainty in this commit. I think Show() was chosen above the old Show() function because with the generic function you can easily constrain the type so only components can be passed to Show and not all types. But Chris can probably explain this better than me.

Finally, I haven't tested this but I think you might be able to do what you want using reflection. See this link for a starting point. Like I said, I haven't tested that at all so it might not work in this specific case.

[chrissainty]

@joseazevedo I've added some new overloads to Show which allow the old type usage. It will be in the next release.

[JAzevedoDev]

Thanks a lot Chris. Chris Sainty <notifications@github.com> escreveu no dia domingo, 19/01/2020 à(s) 10:18:

…

@joseazevedo <https://github.com/joseazevedo> I've added some new overloads to Show which allow the old type usage. It will be in the next release. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#90?email_source=notifications&email_token=AAGBAM36AVM6NDA35DUOQGDQ6QSHVA5CNFSM4KIJPEYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJKOI5Y#issuecomment-575988855>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGBAM36LWPSTYZZZNSUZUTQ6QSHVANCNFSM4KIJPEYA> .

[kiwiingenuity]

Chris,
Really appreciate the new show overloads!
Can you also add these overloads to IModalService please?

[chrissainty]

@kiwiingenuity I've just pushed an update to NuGet. Let me know if you have any problems.

[JAzevedoDev]

Works like a charme. Ty Chris. Chris Sainty <notifications@github.com> escreveu no dia segunda, 10/02/2020 à(s) 14:53:

…

@kiwiingenuity <https://github.com/kiwiingenuity> I've just pushed an update to NuGet. Let me know if you have any problems. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#90?email_source=notifications&email_token=AAGBAM22YJZTZ6JPHS5HCN3RCFS63A5CNFSM4KIJPEYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELIZJ6Y#issuecomment-584160507>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGBAM3F2UF3B2XNBP6YKWDRCFS63ANCNFSM4KIJPEYA> .