Feature/animations #179
Feature/animations #179
Conversation
|
The tests seem to have broken, I hadn't checked those locally. I will have a look at that! |
|
I have fixed the issue of the failing tests. Actually nice having those tests on a Blazor project, caught something that I missed this time. Must have a look at implementing these kind of tests on my own projects as well 😀. |
There was a problem hiding this comment.
Great work as always @larsk2009!
Is there anything else you want to do with this? The only missing thing I could spot was some update to the docs site. Other than that I'm happy to merge.
|
Yes I will add something to the docs. Other than that, I think a lot of different animations could be added but I think it is better to first merge this and see if people like it/use it. If that is the case, more animations could always be added. |
|
@larsk2009 I've merged some changes which have caused a conflict in your PR, apologies. |
|
No problems, I will sort it out in the coming days. |
|
@chrissainty I have incorporated the latest changes you have made and I have added something to the docs and the readme. |
This PR adds support for animations to resolve #166. For now I have made 2 settings available: the duration and the type (fade-in, fade-out or fade-in/fade-out). The way it works is that some CSS is generated for each modal instance. It is sort of 'templated' where Blazor will add the correct values like duration to the CSS. It does feel a little hacky but it seems to work very stable. If anyone has any concerns about that, please let me know!
With this approach a lot of different settings could be added rather quickly I think. One thing I thought of is also exposing the Easing mode of the animation, like ease-in and ease-out, via an enum. Before doing that I would like some feedback on this approach and its usefulness first though.
Global animation settings as well as different animations for multi-modal scenarios are also supported.
Please have a look and see if you like it.