Adds the ability to provide custom layouts for the modal such as Bootstrap #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just had a look over this PR @dfkeenan and it's great work! Is there anything else you plan on doing or is it ready to go? |
|
I am reasonable happy with what I have done. I just updated the samples to include example code. I did not add instructions to the README though. I don't like touching other peoples README. There are probably more advanced options allowing to set a custom layout and still pass in your own content. But I am just getting to know Blazor and thought this simple approach would be good enough for now. If you are happy enough with it I/you can change it to ready for review. And we can merge it. |
chrissainty
approved these changes
Jul 7, 2020
chrissainty
changed the title
|
Glad to help. |
|
Hope to see that update to the nuget. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is an option to use custom layout for modals. Resolves #167.
I have implemented a
ModalOptions.UseCustomLayoutproperty. If you set this totrueit replaces the whole content of theBlazoredModalInstancewith theComponentyou use.Cheers,
dfkeenan