Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#206 | Renamed BlazoredModalInstance Close and Cancel to CloseAsync and CancelAsync #258

Merged
merged 2 commits into from Nov 20, 2020
Merged

Conversation

David-Moreira
Copy link
Contributor

Hello,
Submiting this PR since, the PR:
#207 --> "Renamed BlazoredModalInstance Close and Cancel methods with Async suffix #207"
seems to have gone stale and I already had this sitting on my forked repo.

…nd CancelAsync to follow async naming conventions. (README Included)

DEMOs updated to async.
Copy link
Member

@chrissainty chrissainty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @David-Moreira

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants