Fix for scroll position going to Top when using multple modals #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et to false. As if you have opened multiple modals and close top modal scroll position goes to the top. The only way to stop this behavior in previus version was by using CustomLayout. With this change you only need to set ModalOption>ActivateFocusTrap to false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check for SetFocus for disabling it when ActivateFocusTrap is set to false.
As if you have opened multiple modals and close top modal, scroll position goes to the top. The only way to stop this behavior in before this change is by using CustomLayout. With this change you only need to set ModalOption>ActivateFocusTrap to false.
Before
https://github.com/Blazored/Modal/assets/8648447/715c2b25-12b5-44a3-9e21-5118731dc6aa
After
https://github.com/Blazored/Modal/assets/8648447/ac7df9e6-bee3-4c34-a3cf-c593b65cebca