Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a public method to focus the component #166

Merged
merged 3 commits into from Dec 11, 2020
Merged

Add a public method to focus the component #166

merged 3 commits into from Dec 11, 2020

Conversation

kiasyn
Copy link
Contributor

@kiasyn kiasyn commented Sep 16, 2020

Fixes #150

Copy link
Member

@chrissainty chrissainty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @kiasyn. Just need a couple of things before I can merge it though:

  1. Could you update the Blazor Server sample with the example as well
  2. Could you add a some details to the readme so people know this feature exists and how to use it

Once these bit are done, this can be merged straight away

@zippo-lighter
Copy link

@chrissainty what is blocking the merge into the main repository?

@chrissainty
Copy link
Member

@zippo-lighter As per the comment directly above yours states, there is no documentation or samples for this work.

@chrissainty chrissainty added the Feature New feature that will be added to the project label Dec 11, 2020
@chrissainty chrissainty merged commit 6669f77 into Blazored:main Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature that will be added to the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add a public method to focus the component
3 participants