Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next major version of Blazored Typeahead #46

Merged
merged 8 commits into from
Oct 22, 2019
Merged

Next major version of Blazored Typeahead #46

merged 8 commits into from
Oct 22, 2019

Conversation

chrissainty
Copy link
Member

@chrissainty chrissainty commented Sep 18, 2019

This PR is for the next major version of the Typeahead - It will contain breaking changes

It includes changes based on the work of @pwelter34

Resolves #52
Resolves #40
Resolves #34
Resolves #32
Resolves #53
Resolves #48

@pwelter34
Copy link

@chrissainty thanks for getting this going. been swamp at work and haven't gotten back to this. I'll take a look and see what else i can add value to.

@chrissainty
Copy link
Member Author

No worries, I know what that's like.

That would be great if you could feedback or add anything.

@chrissainty
Copy link
Member Author

@pwelter34 @vertonghenb Do either of you have any comments on this? I want to try and get this next version finalized and think about getting it published.

@chrissainty chrissainty marked this pull request as ready for review October 19, 2019 12:24
@chrissainty
Copy link
Member Author

As I've not heard anything from you @pwelter34 I'm assuming you weren't able to find the time to complete your PR. I really want to get these changes out so I've finished the changes here and I think it's all ready to be merged into master and released.

@vertonghenb I don't suppose you're about to give this a quick review and once over? If not no worries, I'll push the release on Monday if I've not heard anything.

@chrissainty
Copy link
Member Author

Just added the last set of changes. Added multi-select support and I've tidied up all the styling. Now going to merge this is master and sort a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants