Pointcloud #36
Pointcloud #36
Conversation
…also added the option of adding a plane
There was a problem hiding this comment.
Ok, review added, looks good.
Couldn't run it yet , but I looked through the code and adressed a few things like coding style and naming.
Please excuse the brief comments, I didn't have much time.
Also, pay very close attention when fixing the merge conflicts that the program keeps working, because some commits overlap.
pointcloud/point.py
Outdated
| def DoNothing(self): | ||
| return |
There was a problem hiding this comment.
Excellent work on this function! xD
| @@ -31,4 +31,5 @@ | |||
|
|
|||
| root = tk.Tk() | |||
| my_gui = ProgramGUI(root) | |||
| my_gui.pack(fill=tk.BOTH) | |||
There was a problem hiding this comment.
When you get to fixing the merge conflict before merging this PR, make sure to NOT use this code, but instead the code using grid from main.
(This happened because I cherrypicked this commit because I needed it and later changed it)
CreatePointcloudFromObject.py
Outdated
| def convert(self): | ||
|
|
There was a problem hiding this comment.
Rename this function to be named more meaningful, convert can convert anything and doesn't tell that it's for pointclouds.
This is especially important because you import it as a non-prefixed name in gui_main.py.
…g pointcloud, deleted point.py file as it was not used
Pull request to merge the point cloud branch into the main branch