Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't compile version 3.4.0 #434

Closed
lilmike opened this issue Oct 6, 2021 · 6 comments · Fixed by #436
Closed

can't compile version 3.4.0 #434

lilmike opened this issue Oct 6, 2021 · 6 comments · Fixed by #436
Labels
bug Something isn't working
Milestone

Comments

@lilmike
Copy link

lilmike commented Oct 6, 2021

Describe the bug
I've tried compiling Blightmud v1.4.0 on void linux through the package manager, and it has two errors.

errors:

=> Blightmud-3.4.0_1: running do_check ...
   Compiling blightmud v3.4.0 (/builddir/Blightmud-3.4.0)
error[E0308]: mismatched types
  --> src/main.rs:59:13
   |
59 |             data_dir
   |             ^^^^^^^^ expected `()`, found struct `std::path::PathBuf`
   |
help: you might have meant to return this value
   |
59 |             return data_dir;
   |             ^^^^^^         ^
                                                                                                                                                                                                                                                
error[E0308]: mismatched types
  --> src/main.rs:80:13
   |
80 |             config_dir
   |             ^^^^^^^^^^ expected `()`, found struct `std::path::PathBuf`
   |
help: you might have meant to return this value
   |
80 |             return config_dir;
   |             ^^^^^^           ^
                                                                                                                                                                                                                                                
error: aborting due to 2 previous errors
                                                                                                                                                                                                                                                
For more information about this error, try `rustc --explain E0308`.
error: could not compile `blightmud`
                                                                                                                                                                                                                                                
To learn more, run the command again with --verbose.

To Reproduce
Pull https://github.com/lilmike/void-packages, checkout the branch Blightmud, and attempt to build Blightmud on void.

What terminal are you using?
Standard agetty

What mud were you playing?
N/A

Screenshots
None

@lilmike lilmike added the bug Something isn't working label Oct 6, 2021
@LiquidityC
Copy link
Member

Hi, this looks very odd. The compiler errors don't at all conform to standard Rust.
Could you please provide the compile command you are running as well as the output of cargo --version and rustc --version on the building machine.

@LiquidityC
Copy link
Member

Perhaps just paste all the build output too since I don't have Void available. I'll try and figure out the issue from that.

@LiquidityC
Copy link
Member

Oh, and also super cool that Blightmud is a candidate for the Void linux packaging system. Thanks for putting in that work. 🥳

@lilmike
Copy link
Author

lilmike commented Oct 7, 2021 via email

@LiquidityC
Copy link
Member

Ah, I figured it out. You are running this command cargo test --release. That's what's causing the issue due to some macro logic. I'll work on patching it and dropping version 3.4.1.

@LiquidityC LiquidityC added this to the v3.4.1 milestone Oct 7, 2021
@LiquidityC LiquidityC mentioned this issue Oct 7, 2021
@LiquidityC LiquidityC linked a pull request Oct 7, 2021 that will close this issue
@LiquidityC
Copy link
Member

Version 3.4.1 is currently building. It should already work to update the version in your build to 3.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants