Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import does not support ES6 style module export #36

Open
LoveAndCoding opened this issue Nov 21, 2017 · 2 comments
Open

Import does not support ES6 style module export #36

LoveAndCoding opened this issue Nov 21, 2017 · 2 comments

Comments

@LoveAndCoding
Copy link
Contributor

Import supports when a module is exported with the Node module.exports syntax but not the export default ES6 syntax. Sequelize supports both methods under the hood by checking for the type of the export on require. We should be doing the same thing.

First reported in issue #35

@TigerC10
Copy link
Contributor

TigerC10 commented Sep 8, 2018

@ktsashes I've submitted PR #61 (with test cases) to handle this. Would appreciate a review/merge when you can.

litopia added a commit that referenced this issue Oct 17, 2018
#36: Adding ES6 style module support
@nckswt
Copy link

nckswt commented Apr 23, 2020

So #61 was merged, but not part of the release. Right now, my package.json includes this library like:

  "devDependencies": {
    "sequelize-mock": "git://github.com/BlinkUX/sequelize-mock.git#2cc4dbddf8b36f0ba6ff149cac3f33a84494c4ba",
}

Which isn't ideal. Could someone cut a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants