Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for mocking .addScope() #47

Merged
merged 2 commits into from
Jan 22, 2018
Merged

Add support for mocking .addScope() #47

merged 2 commits into from
Jan 22, 2018

Conversation

toxuin
Copy link
Contributor

@toxuin toxuin commented Jan 18, 2018

This adds .addScope() sequelize function, and enables the check for it in tests.

Here is a link to Sequelize's implementation of that function.

@LoveAndCoding LoveAndCoding self-requested a review January 22, 2018 21:27
@LoveAndCoding LoveAndCoding self-assigned this Jan 22, 2018
LoveAndCoding
LoveAndCoding approved these changes Jan 22, 2018
View reviewed changes
Copy link
Contributor

@LoveAndCoding LoveAndCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR

With .scope() being a no-op right now too, this is probably good to have as a no-op too.

@LoveAndCoding LoveAndCoding merged commit 93c5d33 into BlinkUX:master Jan 22, 2018
@toxuin
Copy link
Contributor Author

toxuin commented Feb 7, 2018

I'm sorry to bug you, but when could we expect this to be in some release?.. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoveAndCoding LoveAndCoding LoveAndCoding approved these changes

Assignees

@LoveAndCoding LoveAndCoding

Labels
feature: Models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@toxuin @LoveAndCoding