Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update model.js #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update model.js #88

wants to merge 1 commit into from

Conversation

luiztools
Copy link

Modern Sequelize doesn't have findById anymore, so, we need to change this to add support to findByPk function.

Modern Sequelize doesn't have findById anymore, so, we need to change this to add support to findByPk function.
@tawfiknasser
Copy link

I agree that we need to support findByPk and it should replace it. but this is another functionality.
primary key is not always id. Pk column can be called in many names (id, UUID, ID).

also we need to refactor the tests if we are changing the function name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants