Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: DiskSwapper panel not displayed correctly [ + wiki does not detail hotkeys ] #1118

Closed
giantclambake opened this issue Jun 27, 2023 · 4 comments
Assignees
Labels

Comments

@giantclambake
Copy link

In the wiki we see this;

wiki disk swapper image

With the current git-master build, I see this;

current GUI image

I take it this is some WIP, but clearly this panel needs a scrollbar so user can navigate to/use the 'Remove All' button.

Note: another useful button here would be 'Add Multiple' ~ the ability to add multiple disk image files in one go.

In the helptext for the diskswapper panel, we can read;

current helptext

However in the wiki, no mention of the disk-swapper hotkey functionality is clearly documented ~ it merely intimates hotkeys can be used but not which hotkeys..ie; "You can use this panel to insert multiple floppy disk images (e.g. ADF files) to the multiple slots, and quickly swap between them with hotkey combinations."

I think this is probably an oversight, in as much as (builtin) program documentation should match wiki content (or vice-versa =)

TIA

@midwan
Copy link
Collaborator

midwan commented Jun 27, 2023

The wiki has been updated with the shortcuts (which are coming from WinUAE): https://github.com/BlitterStudio/amiberry/wiki/GUI:-DiskSwapper

I'll update the screenshot later

@midwan
Copy link
Collaborator

midwan commented Jun 27, 2023

Actually, there was a bug introduced here with one of the merges from WinUAE.
DiskSwapper should have only 10 slots as shown in the wiki screenshots, not 20. It was increased to 20 by mistake, but I've fixed that in the preview branch for now (will cherry pick this back to master later).

The description has been updated to better indicate the shortcuts available also. Only the first 4 drives can be used with Insert/Eject disk shortcuts, and those are END + F1-F4 (Insert), or SHIFT + END + F1-F4 (Eject).

I'll have to check if that description about using the numbers actually does anything, I don't recall if I added more shortcuts for swapping disks into drive DF0: for example. :)

@midwan midwan self-assigned this Jun 27, 2023
@midwan midwan added the bug label Jun 27, 2023
@midwan midwan closed this as completed Jun 27, 2023
@giantclambake
Copy link
Author

Don't trouble yourself, as I'll be checking that stuff as a matter of course (and report back anything odd) ~ in the interim I found another so related ; see next ticket =)

@dimitris-norce
Copy link
Contributor

This is already fixed/updated :)

midwan added a commit that referenced this issue Nov 15, 2023
Extra information in the DiskSwapper GUI Panel, to indicate that it can be mapped to custom controls as well
midwan added a commit that referenced this issue Nov 15, 2023
Extra information in the DiskSwapper GUI Panel, to indicate that it can be mapped to custom controls as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants