Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UTF-8 on host filesystem #677

Closed
chris-y opened this issue Aug 7, 2020 · 4 comments
Closed

Use UTF-8 on host filesystem #677

chris-y opened this issue Aug 7, 2020 · 4 comments
Assignees
Labels
enhancement fixed in preview Fixed in the preview branch

Comments

@chris-y
Copy link

chris-y commented Aug 7, 2020

Is your feature request related to a problem? Please describe.
When using a filesystem directory as a hard drive AmiBerry writes files always in the Amiga's charset. This causes weird characters on the Linux side when non-ASCII characters are used on the Amiga filesystem. This makes it difficult to manipulate these files under Linux as they usually can't be typed.

Describe the solution you'd like
Amiga filenames should be translated to/from UTF-8 for Linux filesystem access, probably as an option for compatibility.

@midwan midwan self-assigned this Sep 15, 2020
@midwan
Copy link
Collaborator

midwan commented Dec 5, 2020

@chris-y
Do you have any specific examples of this, please?
Amiberry uses UTF-8 internally, like FS-UAE, for the charset.

@chris-y
Copy link
Author

chris-y commented Dec 7, 2020

Here's the same file, created under Linux with accented characters.

In Linux:
image

In Amiberry:
image

@midwan
Copy link
Collaborator

midwan commented Dec 7, 2020

Thanks for the example, I'll look into this further.

@midwan
Copy link
Collaborator

midwan commented Dec 9, 2020

In fact, the problem here is the opposite:
Linux can save files in UTF-8 without a problem, but AmigaOS does not support UTF-8. The filenames need to be converted to Latin1 when saving, with "invalid" characters being replaced. I'm working on such a solution, partly using logic from FS-UAE's similar approach.

midwan added a commit that referenced this issue Dec 9, 2020
- Fixes filesystem bugs (e.g. IBrowse crash on 2nd startup) (#703)
- Handle translation of UTF8/Latin1 codesets in filesystem (#677)
- Improves bsdsocket implementation somewhat
- Updated VisualGDB and VSLinux projects
@midwan midwan added the fixed in preview Fixed in the preview branch label Dec 9, 2020
@midwan midwan closed this as completed Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement fixed in preview Fixed in the preview branch
Projects
None yet
Development

No branches or pull requests

2 participants