Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could Confluent contribute to the Node.js-librdkafka binding? #540

Closed
solsson opened this issue Dec 14, 2018 · 3 comments
Closed

Could Confluent contribute to the Node.js-librdkafka binding? #540

solsson opened this issue Dec 14, 2018 · 3 comments
Labels
stale Stale issues

Comments

@solsson
Copy link

solsson commented Dec 14, 2018

I'm not a contributor to this project, only a user, but a thought crossed my mind ... @gwenshap (because you were active in envoyproxy/envoy#2852) or someone else at https://github.com/confluentinc/ - wouldn't Confluent be interested in contributing to this client library?

It very much in line with your Kafka clients strategy (afaik clients for C and Java acceptance tested with every Kafka release, bindings to other languages). @webmakersteve is doing a great job following librdkafka. For example the Admin API is supported already.

However based on #531 (comment) and other issues we've followed there's a lot of nitty gritty details with the binding. Maybe just adding node-rdkafka to Confluent's testing and reporting compliance back would help a lot. There should really be a supported Kafka client for such a well-used language as Node.js.

@gwenshap
Copy link

I'm in the wrong team :) But IIRC, our client tests were written so everyone can use them. CC @edenhill for details. Also CC @stanislavkozlovski because he likes Ruby and may be interested.

@solsson
Copy link
Author

solsson commented Dec 17, 2018

I'm the maintainer of https://github.com/Yolean/kubernetes-kafka which I suppose is significantly easier than maintaining a client library. Naturally the client has a lot more users than the provisioning. With Kafka a lot of the complexity lies in the client. Naturally the open source repo becomes some kind of support forum. Support takes time and effort, probably more than the "maintainer" model allows.

At my organization we use both Kafka and Node.js a lot and prior to this library we tried for example https://github.com/oleksiyk/kafka. While it works well we came to the conclusion that going forward we can only stabilize our code if we use official clients. There's lots of intricacies where we'd otherwise not know if it was our code or the client behaving badly.

This client is reliable and up to date, but as Kafka adoption grows it will require increasing resources to support. For example I suspect based on my experience that significant time goes into sorting out if an issue is actually an issue or more a question on the behavior. Maybe you can run tests and document them, as I suggested before, or have people follow this repository and offload the support side of maintenance?

@stale
Copy link

stale bot commented Mar 17, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issues label Mar 17, 2019
@stale stale bot closed this as completed Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale issues
Projects
None yet
Development

No branches or pull requests

2 participants