Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a bunch of new e2e tests #62

Merged
merged 5 commits into from
Nov 18, 2016
Merged

Conversation

mimaison
Copy link
Collaborator

To help catch regressions early, we've added a bunch of new tests to the e2e suites.

The assignment test in consumer.spec.js crashes once in a while:

*** ../deps/librdkafka/src/rdkafka_cgrp.c:790:rd_kafka_cgrp_partitions_fetch_start: assert: rkcg->rkcg_assigned_cnt <= (rkcg->rkcg_assignment ? rkcg->rkcg_assignment->cnt : 0) ***
Aborted (core dumped)

Is it because we're calling it incorrectly or is there a bug somewhere ?

checking for empty key (failing - left pending)
checking for key value
checking ability to send to Topic object
checking for unsubscribe 
checking for assignment
@webmakersteve
Copy link
Contributor

Definitely appreciate adding more unit tests, but it looks like this one isn't passing.

There is an issue with mocha (which is why i shied away from it in the beginning), where if a test fails, it doesn't clean up after itself or force an exit. I'll test this PR locally and see what's going wrong so we can add the extra tests.

Those kind of core dumps are likely on the librdkafka side, but I think that assignment issue is a bug that was fixed in the most recent release of librdkafka. I am trying to get it to work, but there is currently a blocker. But when that gets merged in, it should fix the assignment issue.

changing the test order to avoid librdkafka hanging in 'should get 100%
deliverability' after 'should produce a message to a Topic object'
@edoardocomar
Copy link
Collaborator

We have found that on Ubuntu 14.04, if the producer test
' it('should produce a message to a Topic object'
is run BEFORE it('should get 100% deliverability',
then the latter test hangs.
That was the reason all 4 travis build failed.
It does not happen on MacOS. Changing the order should get the tests to pass in travis - we will need to open an issue for the producer hanging under those circumstances

excluded empty assignment because of
Blizzard#63
@edoardocomar
Copy link
Collaborator

temporarily excluded the consumer.assign([]) test that may cause librdkafka to coredump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants