-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a bunch of new e2e tests #62
Conversation
checking for empty key (failing - left pending) checking for key value checking ability to send to Topic object
checking for unsubscribe checking for assignment
Definitely appreciate adding more unit tests, but it looks like this one isn't passing. There is an issue with mocha (which is why i shied away from it in the beginning), where if a test fails, it doesn't clean up after itself or force an exit. I'll test this PR locally and see what's going wrong so we can add the extra tests. Those kind of core dumps are likely on the librdkafka side, but I think that assignment issue is a bug that was fixed in the most recent release of |
changing the test order to avoid librdkafka hanging in 'should get 100% deliverability' after 'should produce a message to a Topic object'
We have found that on Ubuntu 14.04, if the producer test |
excluded empty assignment because of Blizzard#63
temporarily excluded the |
To help catch regressions early, we've added a bunch of new tests to the e2e suites.
The assignment test in consumer.spec.js crashes once in a while:
Is it because we're calling it incorrectly or is there a bug somewhere ?