fix: release opaque data on error in produce #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is an error trying to produce() messages, no delivery report is ever generated for the message. If the user specified `opaque` data for the message, the call to produce() will has "pinned" it, but with no delivery report, it is never released. This change checks for this condition and releases the opaque data when this happens. Fixes: Blizzard#953
|
Thank you for the PR! |
henrinormak
pushed a commit
to 6fold/node-rdkafka
that referenced
this pull request
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is an error trying to produce() messages,
no delivery report is ever generated for the message.
If the user specified
opaquedata for the message,the call to produce() will have "pinned" it, but with
no delivery report, it is never released. This change
checks for this condition and releases the opaque
data when this happens.
Fixes: #953